NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

sched: walt: fix accounting for throttled deadline task

Browse source 
Task demand update to cumulative runnable average(CRA) is skipped
for throttled deadline tasks, this will result unbalanced accounting
when contribution of such task gets deducted from CRA as part of
dequeue (i.e As their real demand is not updated to CRA under
throttled condition, but as part of dequeue their real demand gets
removed from CRA, thus resulting in unbalanced accounting).

Fix this, by skipping accounting of task demand to CRA only if task
is not in runqueue(as demand for such task gets accounted as part of
enqueue/dequeue).

Change-Id: I1f7df97eee6c9bb9aaf7250e88a812efa921839b
Signed-off-by: Ashay Jaiswal <quic_ashayj@quicinc.com>
This commit is contained in:
Ashay Jaiswal 2024-02-16 22:37:49 +05:30
parent 0dc61da87f
commit 1a01e574a1
1 changed files with 6 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

16
kernel/sched/walt/walt.c
View file

@ -1383,8 +1383,7 @@ static void update_task_pred_demand(struct rq *rq, struct task_struct *p, int ev
new_pred_demand_scaled = get_pred_busy(p, busy_to_bucket(curr_window_scaled),
curr_window_scaled, wts->bucket_bitmask);
if (task_on_rq_queued(p) && (!task_has_dl_policy(p) ||
!p->dl.dl_throttled))
if (task_on_rq_queued(p))
fixup_walt_sched_stats_common(rq, p,
wts->demand_scaled,
new_pred_demand_scaled);
@ -2097,9 +2096,8 @@ static void update_history(struct rq *rq, struct task_struct *p,
demand_scaled = scale_time_to_util(demand);
/*
* A throttled deadline sched class task gets dequeued without
* changing p->on_rq. Since the dequeue decrements walt stats
* avoid decrementing it here again.
* Avoid double accounting of task demand as demand will be updated
* to CRA as part of enqueue/dequeue.
*
* When window is rolled over, the cumulative window demand
* is reset to the cumulative runnable average (contribution from
@ -2108,11 +2106,9 @@ static void update_history(struct rq *rq, struct task_struct *p,
* average. So add the task demand separately to cumulative window
* demand.
*/
if (!task_has_dl_policy(p) || !p->dl.dl_throttled) {
if (task_on_rq_queued(p))
fixup_walt_sched_stats_common(rq, p,
demand_scaled, pred_demand_scaled);
}
if (task_on_rq_queued(p))
fixup_walt_sched_stats_common(rq, p,
demand_scaled, pred_demand_scaled);
wts->demand = demand;
wts->demand_scaled = demand_scaled;