NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

xtensa: ISS: fix call to split_if_spec

Browse source 
commit bc8d5916541fa19ca5bc598eb51a5f78eb891a36 upstream.

split_if_spec expects a NULL-pointer as an end marker for the argument
list, but tuntap_probe never supplied that terminating NULL. As a result
incorrectly formatted interface specification string may cause a crash
because of the random memory access. Fix that by adding NULL terminator
to the split_if_spec argument list.

Cc: stable@vger.kernel.org
Fixes: 7282bee787 ("[PATCH] xtensa: Architecture support for Tensilica Xtensa Part 8")
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Max Filippov 2023-07-03 11:01:42 -07:00 • committed by Greg Kroah-Hartman
parent 6a05de6da5
commit 22fc9fd723
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
arch/xtensa/platforms/iss/network.c
View file

@ -237,7 +237,7 @@ static int tuntap_probe(struct iss_net_private *lp, int index, char *init)
init += sizeof(TRANSPORT_TUNTAP_NAME) - 1; init += sizeof(TRANSPORT_TUNTAP_NAME) - 1;
if (*init == ',') { if (*init == ',') {
rem = split_if_spec(init + 1, &mac_str, &dev_name); rem = split_if_spec(init + 1, &mac_str, &dev_name, NULL);
if (rem != NULL) { if (rem != NULL) {
pr_err("%s: extra garbage on specification : '%s'\n", pr_err("%s: extra garbage on specification : '%s'\n",
dev->name, rem); dev->name, rem);