From 48c73395b4eb492ef74a94d3cf0c8ff397b32c9a Mon Sep 17 00:00:00 2001 From: Kathiravan T Date: Wed, 17 May 2023 11:55:20 +0530 Subject: [PATCH] firmware: qcom_scm: updated commit text for usage of SMC_CONVENTION_ARM_32 updated commit text in scm driver for usage of SMC_CONVENTION_ARM_64 for 64bit kernel and SMC_CONVENTION_ARM_32 for 32bit kernel. Change-Id: I84eefd91a00e303b80388e43f59dc5c914352bca Signed-off-by: Kathiravan T --- drivers/firmware/qcom_scm.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c index 9c015d4c3adc..fcbb55f9a81e 100644 --- a/drivers/firmware/qcom_scm.c +++ b/drivers/firmware/qcom_scm.c @@ -207,6 +207,10 @@ static enum qcom_scm_convention __get_convention(void) * Per the "SMC calling convention specification", the 64-bit calling * convention can only be used when the client is 64-bit, otherwise * system will encounter the undefined behaviour. + * When running on 32bit kernel, SCM call with convention + * SMC_CONVENTION_ARM_64 is causing the system crash. To avoid that + * use SMC_CONVENTION_ARM_64 for 64bit kernel and SMC_CONVENTION_ARM_32 + * for 32bit kernel. */ #if IS_ENABLED(CONFIG_ARM64) /*