NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()

Browse source 
[ Upstream commit 235f2b548d7f4ac5931d834f05d3f7f5166a2e72 ]

When an error occurs in the for loop of beiscsi_init_wrb_handle(), we
should free phwi_ctxt->be_wrbq before returning an error code to prevent
potential memleak.

Fixes: a7909b396b ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20231123081941.24854-1-dinghao.liu@zju.edu.cn
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Dinghao Liu 2023-11-23 16:19:41 +08:00 • committed by Greg Kroah-Hartman
parent bc5b79df6d
commit 4d8cc87d18
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
drivers/scsi/be2iscsi/be_main.c
View file

@ -2710,6 +2710,7 @@ init_wrb_hndl_failed:
kfree(pwrb_context->pwrb_handle_base); kfree(pwrb_context->pwrb_handle_base);
kfree(pwrb_context->pwrb_handle_basestd); kfree(pwrb_context->pwrb_handle_basestd);
} }
kfree(phwi_ctxt->be_wrbq);
return -ENOMEM; return -ENOMEM;
} }