NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc: ti: pm33xx: Fix refcount leak in am33xx_pm_probe

Browse source 
[ Upstream commit 8f3c307b580a4a6425896007325bddefc36e8d91 ]

wkup_m3_ipc_get() takes refcount, which should be freed by
wkup_m3_ipc_put(). Add missing refcount release in the error paths.

Fixes: 5a99ae0092 ("soc: ti: pm33xx: AM437X: Add rtc_only with ddr in self-refresh support")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20230106054022.947529-1-linmq006@gmail.com
Signed-off-by: Nishanth Menon <nm@ti.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Miaoqian Lin 2023-01-06 09:40:22 +04:00 • committed by Greg Kroah-Hartman
parent f5222fbd79
commit 6dbcc493a1
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
drivers/soc/ti/pm33xx.c
View file

@ -527,7 +527,7 @@ static int am33xx_pm_probe(struct platform_device *pdev)
ret = am33xx_pm_alloc_sram(); ret = am33xx_pm_alloc_sram();
if (ret) if (ret)
return ret; goto err_wkup_m3_ipc_put;
ret = am33xx_pm_rtc_setup(); ret = am33xx_pm_rtc_setup();
if (ret) if (ret)
@ -572,13 +572,14 @@ err_pm_runtime_put:
pm_runtime_put_sync(dev); pm_runtime_put_sync(dev);
err_pm_runtime_disable: err_pm_runtime_disable:
pm_runtime_disable(dev); pm_runtime_disable(dev);
wkup_m3_ipc_put(m3_ipc);
err_unsetup_rtc: err_unsetup_rtc:
iounmap(rtc_base_virt); iounmap(rtc_base_virt);
clk_put(rtc_fck); clk_put(rtc_fck);
err_free_sram: err_free_sram:
am33xx_pm_free_sram(); am33xx_pm_free_sram();
pm33xx_dev = NULL; pm33xx_dev = NULL;
err_wkup_m3_ipc_put:
wkup_m3_ipc_put(m3_ipc);
return ret; return ret;
} }