NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Revert "usb: gadget: udc: core: Prevent redundant calls to pullup"

Browse source 
commit 5e1617210aede9f1b91bb9819c93097b6da481f9 upstream.

This reverts commit a3afbf5cc887fc3401f012fe629810998ed61859.

This depends on commit 0db213ea8eed ("usb: gadget: udc: core: Invoke
usb_gadget_connect only when started") that introduces a regression,
revert it till the issue is fixed.

Cc: stable@vger.kernel.org
Reported-by: Stephan Gerhold <stephan@gerhold.net>
Reported-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Link: https://lore.kernel.org/all/ZF4BvgsOyoKxdPFF@francesco-nb.int.toradex.com/
Signed-off-by: Francesco Dolcini <francesco.dolcini@toradex.com>
Link: https://lore.kernel.org/r/20230512131435.205464-2-francesco@dolcini.it
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Francesco Dolcini 2023-05-12 15:14:34 +02:00 • committed by Greg Kroah-Hartman
parent 08bd1be1c7
commit 7356d42cef
1 changed files with 0 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
drivers/usb/gadget/udc/core.c
View file

@ -676,9 +676,6 @@ static int usb_gadget_connect_locked(struct usb_gadget *gadget)
goto out; goto out;
} }
if (gadget->connected)
goto out;
if (gadget->deactivated || !gadget->udc->started) { if (gadget->deactivated || !gadget->udc->started) {
/* /*
* If gadget is deactivated we only save new state. * If gadget is deactivated we only save new state.