diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 1853a18a457e..7a88177b5fe5 100644 --- a/drivers/mmc/core/block.c +++ b/drivers/mmc/core/block.c @@ -2408,10 +2408,8 @@ enum mmc_issued mmc_blk_mq_issue_rq(struct mmc_queue *mq, struct request *req) } ret = mmc_blk_cqe_issue_flush(mq, req); break; - case REQ_OP_WRITE: - card->written_flag = true; - fallthrough; case REQ_OP_READ: + case REQ_OP_WRITE: if (host->cqe_enabled) ret = mmc_blk_cqe_issue_rw_rq(mq, req); else diff --git a/drivers/mmc/core/card.h b/drivers/mmc/core/card.h index b7754a1b8d97..4edf9057fa79 100644 --- a/drivers/mmc/core/card.h +++ b/drivers/mmc/core/card.h @@ -280,8 +280,4 @@ static inline int mmc_card_broken_sd_cache(const struct mmc_card *c) return c->quirks & MMC_QUIRK_BROKEN_SD_CACHE; } -static inline int mmc_card_broken_cache_flush(const struct mmc_card *c) -{ - return c->quirks & MMC_QUIRK_BROKEN_CACHE_FLUSH; -} #endif diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c index edb20ba34108..693aef94974a 100644 --- a/drivers/mmc/core/mmc.c +++ b/drivers/mmc/core/mmc.c @@ -2088,17 +2088,13 @@ static int _mmc_flush_cache(struct mmc_host *host) { int err = 0; - if (mmc_card_broken_cache_flush(host->card) && !host->card->written_flag) - return 0; - if (_mmc_cache_enabled(host)) { err = mmc_switch(host->card, EXT_CSD_CMD_SET_NORMAL, EXT_CSD_FLUSH_CACHE, 1, CACHE_FLUSH_TIMEOUT_MS); if (err) - pr_err("%s: cache flush error %d\n", mmc_hostname(host), err); - else - host->card->written_flag = false; + pr_err("%s: cache flush error %d\n", + mmc_hostname(host), err); } return err; diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h index ec760ac0b397..857315f185fc 100644 --- a/drivers/mmc/core/quirks.h +++ b/drivers/mmc/core/quirks.h @@ -117,12 +117,11 @@ static const struct mmc_fixup __maybe_unused mmc_blk_fixups[] = { MMC_QUIRK_TRIM_BROKEN), /* - * Micron MTFC4GACAJCN-1M supports TRIM but does not appear to support - * WRITE_ZEROES offloading. It also supports caching, but the cache can - * only be flushed after a write has occurred. + * Micron MTFC4GACAJCN-1M advertises TRIM but it does not seems to + * support being used to offload WRITE_ZEROES. */ MMC_FIXUP("Q2J54A", CID_MANFID_MICRON, 0x014e, add_quirk_mmc, - MMC_QUIRK_TRIM_BROKEN | MMC_QUIRK_BROKEN_CACHE_FLUSH), + MMC_QUIRK_TRIM_BROKEN), /* * Some SD cards reports discard support while they don't diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h index 2a29cdb35e7e..3ce869bc643c 100644 --- a/include/linux/mmc/card.h +++ b/include/linux/mmc/card.h @@ -298,9 +298,7 @@ struct mmc_card { #define MMC_QUIRK_BROKEN_HPI (1<<13) /* Disable broken HPI support */ #define MMC_QUIRK_BROKEN_SD_DISCARD (1<<14) /* Disable broken SD discard support */ #define MMC_QUIRK_BROKEN_SD_CACHE (1<<15) /* Disable broken SD cache support */ -#define MMC_QUIRK_BROKEN_CACHE_FLUSH (1<<16) /* Don't flush cache until the write has occurred */ - bool written_flag; /* Indicates eMMC has been written since power on */ bool reenable_cmdq; /* Re-enable Command Queue */ unsigned int erase_size; /* erase size in sectors */