NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

soc: logbuf: Miscellaneous fixes

Browse source 
Let's remove unused variable 'ret' qcom_logbuf_vendor_hooks
driver and also fix one boot log warning from qcom_logbuf_boot_log
driver.


 5.120964][  T401] do_init_module: 'qcom_logbuf_boot_log'->init
 suspiciously returned 47, it should follow 0/-E convention.

Change-Id: I502ed5a9b2218627d2bdd20e1fa5ce2985a53bff
Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
This commit is contained in:
Mukesh Ojha 2023-12-28 14:11:26 +05:30
parent 1d8d22bd2a
commit 8ea85c847b
2 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
drivers/soc/qcom/qcom_logbuf_boot_log.c
View file

@ -83,6 +83,8 @@ static int __init boot_log_dump_init(void)
size_t text_len;
ret = boot_log_init();
if (ret < 0)
return ret;
kmsg_dump_rewind(&iter);
dumped_line = iter.next_seq;
@ -92,7 +94,7 @@ static int __init boot_log_dump_init(void)
iter.cur_seq = dumped_line;
dump_thread = kthread_run(dump_thread_func, NULL, "dump_thread");
return ret;
return 0;
}
late_initcall(boot_log_dump_init);

3
drivers/soc/qcom/qcom_logbuf_vendor_hooks.c
View file

@ -66,7 +66,6 @@ void register_log_minidump(struct printk_ringbuffer *prb)
static int logbuf_vh_driver_probe(struct platform_device *pdev)
{
int ret = 0;
struct printk_ringbuffer *prb = NULL;
if (!debug_symbol_available())
@ -75,7 +74,7 @@ static int logbuf_vh_driver_probe(struct platform_device *pdev)
prb = *(struct printk_ringbuffer **)DEBUG_SYMBOL_LOOKUP(prb);
register_log_minidump(prb);
return ret;
return 0;
}
static int logbuf_vh_driver_remove(struct platform_device *pdev)