NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

netfilter: nf_tables: Drop pointless memset when dumping rules

Browse source 
[ Upstream commit 30fa41a0f6df4c85790cc6499ddc4a926a113bfa ]

None of the dump callbacks uses netlink_callback::args beyond the first
element, no need to zero the data.

Fixes: 96518518cc ("netfilter: add nftables")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Phil Sutter 2023-09-29 21:19:19 +02:00 • committed by Greg Kroah-Hartman
parent 100a75d56b
commit 9709c6d759
1 changed files with 0 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
net/netfilter/nf_tables_api.c
View file

@ -3279,10 +3279,6 @@ static int __nf_tables_dump_rules(struct sk_buff *skb,
goto cont_skip; goto cont_skip;
if (*idx < s_idx) if (*idx < s_idx)
goto cont; goto cont;
if (*idx > s_idx) {
memset(&cb->args[1], 0,
sizeof(cb->args) - sizeof(cb->args[0]));
}
if (prule) if (prule)
handle = prule->handle; handle = prule->handle;
else else