NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ksmbd: fix memory leak in smb2_lock()

Browse source 
[ Upstream commit 8f1752723019db900fb60a5b9d0dfd3a2bdea36c ]

In smb2_lock(), if setup_async_work() executes successfully,
work->cancel_argv will bind the argv that generated by kmalloc(). And
release_async_work() is called in ksmbd_conn_try_dequeue_request() or
smb2_lock() to release argv.
However, when setup_async_work function fails, work->cancel_argv has not
been bound to the argv, resulting in the previously allocated argv not
being released. Call kfree() to fix it.

Fixes: e2f34481b2 ("cifsd: add server-side procedures for SMB3")
Signed-off-by: Zizhi Wo <wozizhi@huawei.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Zizhi Wo 2023-12-01 22:50:48 +08:00 • committed by Greg Kroah-Hartman
parent 8925ab33b3
commit a7e6477cc3
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
fs/smb/server/smb2pdu.c
View file

@ -7135,6 +7135,7 @@ skip:
smb2_remove_blocked_lock, smb2_remove_blocked_lock,
argv); argv);
if (rc) { if (rc) {
kfree(argv);
err = -ENOMEM; err = -ENOMEM;
goto out; goto out;
} }