NothingOSS/android_kernel_msm-6.1_nothing_sm7635
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

ksmbd: Fix unsigned expression compared with zero

Browse source 
[ Upstream commit 0266a2f791294e0b4ba36f4a1d89b8615ea3cac0 ]

The return value of the ksmbd_vfs_getcasexattr() is signed.
However, the return value is being assigned to an unsigned
variable and subsequently recasted, causing warnings. Use
a signed type.

Signed-off-by: Wang Ming <machel@vivo.com>
Acked-by: Tom Talpey <tom@talpey.com>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
Wang Ming 2023-12-31 16:12:51 +09:00 • committed by Greg Kroah-Hartman
parent 48cc493840
commit d782f42eed
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
fs/smb/server/vfs.c
View file

@ -413,7 +413,8 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
{ {
char *stream_buf = NULL, *wbuf; char *stream_buf = NULL, *wbuf;
struct user_namespace *user_ns = file_mnt_user_ns(fp->filp); struct user_namespace *user_ns = file_mnt_user_ns(fp->filp);
size_t size, v_len; size_t size;
ssize_t v_len;
int err = 0; int err = 0;
ksmbd_debug(VFS, "write stream data pos : %llu, count : %zd\n", ksmbd_debug(VFS, "write stream data pos : %llu, count : %zd\n",
@ -430,9 +431,9 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *fp, char *buf, loff_t *pos,
fp->stream.name, fp->stream.name,
fp->stream.size, fp->stream.size,
&stream_buf); &stream_buf);
if ((int)v_len < 0) { if (v_len < 0) {
pr_err("not found stream in xattr : %zd\n", v_len); pr_err("not found stream in xattr : %zd\n", v_len);
err = (int)v_len; err = v_len;
goto out; goto out;
} }