From 8ea85c847bc1304ed4e45a636d8cda22fbe48748 Mon Sep 17 00:00:00 2001 From: Mukesh Ojha Date: Thu, 28 Dec 2023 14:11:26 +0530 Subject: [PATCH] soc: logbuf: Miscellaneous fixes Let's remove unused variable 'ret' qcom_logbuf_vendor_hooks driver and also fix one boot log warning from qcom_logbuf_boot_log driver. 5.120964][ T401] do_init_module: 'qcom_logbuf_boot_log'->init suspiciously returned 47, it should follow 0/-E convention. Change-Id: I502ed5a9b2218627d2bdd20e1fa5ce2985a53bff Signed-off-by: Mukesh Ojha --- drivers/soc/qcom/qcom_logbuf_boot_log.c | 4 +++- drivers/soc/qcom/qcom_logbuf_vendor_hooks.c | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/soc/qcom/qcom_logbuf_boot_log.c b/drivers/soc/qcom/qcom_logbuf_boot_log.c index 6183a8ce1831..f115daa1a996 100644 --- a/drivers/soc/qcom/qcom_logbuf_boot_log.c +++ b/drivers/soc/qcom/qcom_logbuf_boot_log.c @@ -83,6 +83,8 @@ static int __init boot_log_dump_init(void) size_t text_len; ret = boot_log_init(); + if (ret < 0) + return ret; kmsg_dump_rewind(&iter); dumped_line = iter.next_seq; @@ -92,7 +94,7 @@ static int __init boot_log_dump_init(void) iter.cur_seq = dumped_line; dump_thread = kthread_run(dump_thread_func, NULL, "dump_thread"); - return ret; + return 0; } late_initcall(boot_log_dump_init); diff --git a/drivers/soc/qcom/qcom_logbuf_vendor_hooks.c b/drivers/soc/qcom/qcom_logbuf_vendor_hooks.c index 0225f05d2186..1901f9b31ebb 100644 --- a/drivers/soc/qcom/qcom_logbuf_vendor_hooks.c +++ b/drivers/soc/qcom/qcom_logbuf_vendor_hooks.c @@ -66,7 +66,6 @@ void register_log_minidump(struct printk_ringbuffer *prb) static int logbuf_vh_driver_probe(struct platform_device *pdev) { - int ret = 0; struct printk_ringbuffer *prb = NULL; if (!debug_symbol_available()) @@ -75,7 +74,7 @@ static int logbuf_vh_driver_probe(struct platform_device *pdev) prb = *(struct printk_ringbuffer **)DEBUG_SYMBOL_LOOKUP(prb); register_log_minidump(prb); - return ret; + return 0; } static int logbuf_vh_driver_remove(struct platform_device *pdev)