Bernd Eckstein 45611c61dd usbnet: ipheth: fix potential recvmsg bug and recvmsg bug 2 ... The bug is not easily reproducable, as it may occur very infrequently (we had machines with 20minutes heavy downloading before it occurred) However, on a virual machine (VMWare on Windows 10 host) it occurred pretty frequently (1-2 seconds after a speedtest was started) dev->tx_skb mab be freed via dev_kfree_skb_irq on a callback before it is set. This causes the following problems: - double free of the skb or potential memory leak - in dmesg: 'recvmsg bug' and 'recvmsg bug 2' and eventually general protection fault Example dmesg output: [ 134.841986] ------------[ cut here ]------------ [ 134.841987] recvmsg bug: copied 9C24A555 seq 9C24B557 rcvnxt 9C25A6B3 fl 0 [ 134.841993] WARNING: CPU: 7 PID: 2629 at /build/linux-hwe-On9fm7/linux-hwe-4.15.0/net/ipv4/tcp.c:1865 tcp_recvmsg+0x44d/0xab0 [ 134.841994] Modules linked in: ipheth(OE) kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd vmw_balloon intel_rapl_perf joydev input_leds serio_raw vmw_vsock_vmci_transport vsock shpchp i2c_piix4 mac_hid binfmt_misc vmw_vmci parport_pc ppdev lp parport autofs4 vmw_pvscsi vmxnet3 hid_generic usbhid hid vmwgfx ttm drm_kms_helper syscopyarea sysfillrect mptspi mptscsih sysimgblt ahci psmouse fb_sys_fops pata_acpi mptbase libahci e1000 drm scsi_transport_spi [ 134.842046] CPU: 7 PID: 2629 Comm: python Tainted: G W OE 4.15.0-34-generic #37~16.04.1-Ubuntu [ 134.842046] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/19/2017 [ 134.842048] RIP: 0010:tcp_recvmsg+0x44d/0xab0 [ 134.842048] RSP: 0018:ffffa6630422bcc8 EFLAGS: 00010286 [ 134.842049] RAX: 0000000000000000 RBX: ffff997616f4f200 RCX: 0000000000000006 [ 134.842049] RDX: 0000000000000007 RSI: 0000000000000082 RDI: ffff9976257d6490 [ 134.842050] RBP: ffffa6630422bd98 R08: 0000000000000001 R09: 000000000004bba4 [ 134.842050] R10: 0000000001e00c6f R11: 000000000004bba4 R12: ffff99760dee3000 [ 134.842051] R13: 0000000000000000 R14: ffff99760dee3514 R15: 0000000000000000 [ 134.842051] FS: 00007fe332347700(0000) GS:ffff9976257c0000(0000) knlGS:0000000000000000 [ 134.842052] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 134.842053] CR2: 0000000001e41000 CR3: 000000020e9b4006 CR4: 00000000003606e0 [ 134.842055] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 134.842055] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 134.842057] Call Trace: [ 134.842060] ? aa_sk_perm+0x53/0x1a0 [ 134.842064] inet_recvmsg+0x51/0xc0 [ 134.842066] sock_recvmsg+0x43/0x50 [ 134.842070] SYSC_recvfrom+0xe4/0x160 [ 134.842072] ? __schedule+0x3de/0x8b0 [ 134.842075] ? ktime_get_ts64+0x4c/0xf0 [ 134.842079] SyS_recvfrom+0xe/0x10 [ 134.842082] do_syscall_64+0x73/0x130 [ 134.842086] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 134.842086] RIP: 0033:0x7fe331f5a81d [ 134.842088] RSP: 002b:00007ffe8da98398 EFLAGS: 00000246 ORIG_RAX: 000000000000002d [ 134.842090] RAX: ffffffffffffffda RBX: ffffffffffffffff RCX: 00007fe331f5a81d [ 134.842094] RDX: 00000000000003fb RSI: 0000000001e00874 RDI: 0000000000000003 [ 134.842095] RBP: 00007fe32f642c70 R08: 0000000000000000 R09: 0000000000000000 [ 134.842097] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe332347698 [ 134.842099] R13: 0000000001b7e0a0 R14: 0000000001e00874 R15: 0000000000000000 [ 134.842103] Code: 24 fd ff ff e9 cc fe ff ff 48 89 d8 41 8b 8c 24 10 05 00 00 44 8b 45 80 48 c7 c7 08 bd 59 8b 48 89 85 68 ff ff ff e8 b3 c4 7d ff <0f> 0b 48 8b 85 68 ff ff ff e9 e9 fe ff ff 41 8b 8c 24 10 05 00 [ 134.842126] ---[ end trace b7138fc08c83147f ]--- [ 134.842144] general protection fault: 0000 [#1] SMP PTI [ 134.842145] Modules linked in: ipheth(OE) kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd vmw_balloon intel_rapl_perf joydev input_leds serio_raw vmw_vsock_vmci_transport vsock shpchp i2c_piix4 mac_hid binfmt_misc vmw_vmci parport_pc ppdev lp parport autofs4 vmw_pvscsi vmxnet3 hid_generic usbhid hid vmwgfx ttm drm_kms_helper syscopyarea sysfillrect mptspi mptscsih sysimgblt ahci psmouse fb_sys_fops pata_acpi mptbase libahci e1000 drm scsi_transport_spi [ 134.842161] CPU: 7 PID: 2629 Comm: python Tainted: G W OE 4.15.0-34-generic #37~16.04.1-Ubuntu [ 134.842162] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 05/19/2017 [ 134.842164] RIP: 0010:tcp_close+0x2c6/0x440 [ 134.842165] RSP: 0018:ffffa6630422bde8 EFLAGS: 00010202 [ 134.842167] RAX: 0000000000000000 RBX: ffff99760dee3000 RCX: 0000000180400034 [ 134.842168] RDX: 5c4afd407207a6c4 RSI: ffffe868495bd300 RDI: ffff997616f4f200 [ 134.842169] RBP: ffffa6630422be08 R08: 0000000016f4d401 R09: 0000000180400034 [ 134.842169] R10: ffffa6630422bd98 R11: 0000000000000000 R12: 000000000000600c [ 134.842170] R13: 0000000000000000 R14: ffff99760dee30c8 R15: ffff9975bd44fe00 [ 134.842171] FS: 00007fe332347700(0000) GS:ffff9976257c0000(0000) knlGS:0000000000000000 [ 134.842173] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 134.842174] CR2: 0000000001e41000 CR3: 000000020e9b4006 CR4: 00000000003606e0 [ 134.842177] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 134.842178] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 134.842179] Call Trace: [ 134.842181] inet_release+0x42/0x70 [ 134.842183] __sock_release+0x42/0xb0 [ 134.842184] sock_close+0x15/0x20 [ 134.842187] __fput+0xea/0x220 [ 134.842189] ____fput+0xe/0x10 [ 134.842191] task_work_run+0x8a/0xb0 [ 134.842193] exit_to_usermode_loop+0xc4/0xd0 [ 134.842195] do_syscall_64+0xf4/0x130 [ 134.842197] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 134.842197] RIP: 0033:0x7fe331f5a560 [ 134.842198] RSP: 002b:00007ffe8da982e8 EFLAGS: 00000246 ORIG_RAX: 0000000000000003 [ 134.842200] RAX: 0000000000000000 RBX: 00007fe32f642c70 RCX: 00007fe331f5a560 [ 134.842201] RDX: 00000000008f5320 RSI: 0000000001cd4b50 RDI: 0000000000000003 [ 134.842202] RBP: 00007fe32f6500f8 R08: 000000000000003c R09: 00000000009343c0 [ 134.842203] R10: 0000000000000000 R11: 0000000000000246 R12: 00007fe32f6500d0 [ 134.842204] R13: 00000000008f5320 R14: 00000000008f5320 R15: 0000000001cd4770 [ 134.842205] Code: c8 00 00 00 45 31 e4 49 39 fe 75 4d eb 50 83 ab d8 00 00 00 01 48 8b 17 48 8b 47 08 48 c7 07 00 00 00 00 48 c7 47 08 00 00 00 00 <48> 89 42 08 48 89 10 0f b6 57 34 8b 47 2c 2b 47 28 83 e2 01 80 [ 134.842226] RIP: tcp_close+0x2c6/0x440 RSP: ffffa6630422bde8 [ 134.842227] ---[ end trace b7138fc08c831480 ]--- The proposed patch eliminates a potential racing condition. Before, usb_submit_urb was called and _after_ that, the skb was attached (dev->tx_skb). So, on a callback it was possible, however unlikely that the skb was freed before it was set. That way (because dev->tx_skb was not set to NULL after it was freed), it could happen that a skb from a earlier transmission was freed a second time (and the skb we should have freed did not get freed at all) Now we free the skb directly in ipheth_tx(). It is not passed to the callback anymore, eliminating the posibility of a double free of the same skb. Depending on the retval of usb_submit_urb() we use dev_kfree_skb_any() respectively dev_consume_skb_any() to free the skb. Signed-off-by: Oliver Zweigle <Oliver.Zweigle@faro.com> Signed-off-by: Bernd Eckstein <3ernd.Eckstein@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-11-27 14:57:16 -08:00
..
accessibility
acpi	ACPI / platform: Add SMB0001 HID to forbidden_id_list	2018-11-21 13:30:13 +01:00
amba
android
ata	libata: blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD	2018-11-12 12:44:19 -07:00
atm	atm: zatm: Fix empty body Clang warnings	2018-10-18 15:39:10 -07:00
auxdisplay	The Compiler Attributes series	2018-11-01 18:34:46 -07:00
base	mm/memory_hotplug: fix online/offline_pages called w.o. mem_hotplug_lock	2018-10-31 08:54:17 -07:00
bcma
block	for-linus-20181115	2018-11-16 09:31:59 -06:00
bluetooth	Merge branch 'work.tty-ioctl' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-10-24 14:43:41 +01:00
bus	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
cdrom	gdrom: fix mistake in assignment of error	2018-10-25 11:17:40 -06:00
char	RTC for 4.20	2018-10-27 09:24:24 -07:00
clk	clk: qcom: gcc: Fix board clock node name	2018-11-09 14:13:55 -08:00
clocksource	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-11-11 16:41:50 -06:00
connector
cpufreq	cpufreq: ti-cpufreq: Only register platform_device when supported	2018-11-19 11:26:06 +01:00
cpuidle	ARM: cpuidle: Convert to use cpuidle_register|unregister()	2018-11-08 18:53:00 +01:00
crypto	crypto: hisilicon - Fix reference after free of memories on error path	2018-11-09 17:35:43 +08:00
dax
dca
devfreq
dio
dma	pci-v4.20-changes	2018-10-25 06:50:48 -07:00
dma-buf	udmabuf: set read/write flag when exporting	2018-11-16 08:50:53 +01:00
edac	* skx_edac: Address translation for NVDIMMs (Tony Luck and Qiuxu Zhuo)	2018-11-02 11:17:22 -07:00
eisa
extcon
firewire
firmware	efi: Permit calling efi_mem_reserve_persistent() from atomic context	2018-11-15 10:04:47 +01:00
fmc
fpga	fpga: add devm_fpga_region_create	2018-10-16 11:13:50 +02:00
fsi	iov_iter: Separate type from direction and use accessor functions	2018-10-24 00:41:07 +01:00
gnss	gnss: sirf: fix synchronous write timeout	2018-11-14 20:37:41 +01:00
gpio	gpio: mockup: fix indicated direction	2018-11-16 23:06:29 +01:00
gpu	Merge tag 'drm-intel-fixes-2018-11-22' of git://anongit.freedesktop.org/drm/drm-intel into drm-fixes	2018-11-23 11:03:21 +10:00
hid	HID: asus: fix build warning wiht CONFIG_ASUS_WMI disabled	2018-11-06 13:57:42 +01:00
hsi
hv	Drivers: hv: kvp: Fix the recent regression caused by incorrect clean-up	2018-11-11 09:00:20 -08:00
hwmon	hwmon: (ibmpowernv) Remove bogus __init annotations	2018-11-04 15:55:12 -08:00
hwspinlock
hwtracing
i2c	i2c: nvidia-gpu: make pm_ops static	2018-11-09 17:56:44 +01:00
ide
idle	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
iio	Staging/IIO patches for 4.20-rc1	2018-10-29 10:38:10 -07:00
infiniband	Revert "mm, mmu_notifier: annotate mmu notifiers with blockable invalidate callbacks"	2018-10-26 16:25:19 -07:00
input	Merge branch 'xarray' of git://git.infradead.org/users/willy/linux-dax	2018-10-28 11:35:40 -07:00
iommu	iommu/vt-d: Use memunmap to free memremap	2018-11-22 17:02:21 +01:00
ipack
irqchip	irqchip/irq-mvebu-sei: Fix a NULL vs IS_ERR() bug in probe function	2018-11-01 12:38:48 +01:00
isdn	Merge branch 'work.afs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2018-11-01 19:58:52 -07:00
leds	LED fixes for 4.20-rc2	2018-11-08 17:49:04 -06:00
lightnvm
macintosh	memblock: stop using implicit alignment to SMP_CACHE_BYTES	2018-10-31 08:54:16 -07:00
mailbox	- Convert print users to use the %pOFn format specifier	2018-10-29 10:30:44 -07:00
mcb
md	for-linus-20181102	2018-11-02 11:25:48 -07:00
media	media: ipu3-cio2: Use cio2_queues_exit	2018-11-06 07:11:59 -05:00
memory
memstick
message
mfd	chrome-platform for v4.20	2018-10-31 16:47:55 -07:00
misc	misc: atmel-ssc: Fix section annotation on atmel_ssc_get_driver_data	2018-11-11 09:13:19 -08:00
mmc	mmc: sdhci-pci: Workaround GLK firmware failing to restore the tuning value	2018-11-19 14:11:07 +01:00
mtd	mtd: spi-nor: fix selection of uniform erase type in flexible conf	2018-11-20 14:26:59 +01:00
mux	This is the bulk of GPIO changes for the v4.20 series:	2018-10-23 08:45:05 +01:00
net	usbnet: ipheth: fix potential recvmsg bug and recvmsg bug 2	2018-11-27 14:57:16 -08:00
nfc	NFC: nfcmrvl_uart: fix OF child-node lookup	2018-10-23 13:28:53 -05:00
ntb	ntb: idt: Alter the driver info comments	2018-11-01 10:33:12 -04:00
nubus
nvdimm	libnvdimm for 4.20	2018-10-25 06:31:56 -07:00
nvme	nvme-fc: resolve io failures during connect	2018-11-15 11:37:55 +01:00
nvmem	nvmem: core: fix regression in of_nvmem_cell_get()	2018-11-11 09:15:29 -08:00
of	Devicetree fixes for 4.20-rc:	2018-11-09 16:41:58 -06:00
opp	opp: ti-opp-supply: Correct the supply in _get_optimal_vdd_voltage call	2018-11-13 09:40:29 +05:30
oprofile
parisc	parisc: Add alternative coding infrastructure	2018-10-17 17:22:26 +02:00
parport
pci	Revert "ACPI/PCI: Pay attention to device-specific _PXM node values"	2018-11-13 08:38:17 -06:00
pcmcia	powerpc updates for 4.20	2018-10-26 14:36:21 -07:00
perf	arm64 updates for 4.20:	2018-10-22 17:30:06 +01:00
phy	USB/PHY patches for 4.20-rc1	2018-10-26 08:14:13 -07:00
pinctrl	pinctrl: meson: fix meson8b ao pull register bits	2018-11-05 09:33:22 +01:00
platform	platform-drivers-x86 for v4.20-1	2018-11-01 08:42:21 -07:00
pnp
power	Devicetree updates for 4.20:	2018-10-26 12:09:58 -07:00
powercap	Merge branch 'perf-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2018-10-23 13:32:18 +01:00
pps
ps3
ptp	ptp: drop redundant kasprintf() to create worker name	2018-10-28 19:20:06 -07:00
pwm	pwm: lpss: Only set update bit if we are actually changing the settings	2018-10-16 13:16:15 +02:00
rapidio
ras
regulator	regulator: Regulator updates for next release	2018-10-23 01:54:44 +01:00
remoteproc	remoteproc: qcom: q6v5-mss: Register segments/dumpfn for coredump	2018-10-19 12:54:03 -07:00
reset	ARM: SoC driver updates for 4.17	2018-10-29 15:16:01 -07:00
rpmsg
rtc	rtc: pcf2127: fix a kmemleak caused in pcf2127_i2c_gather_write	2018-11-07 17:13:56 +01:00
s390	s390/ism: clear dmbe_mask bit before SMC IRQ handling	2018-11-14 14:21:20 -08:00
sbus
scsi	SCSI fixes on 20181121	2018-11-22 08:31:46 -08:00
sfi	mm: remove include/linux/bootmem.h	2018-10-31 08:54:16 -07:00
sh
siox
slimbus	slimbus: ngd: remove unnecessary check	2018-11-07 14:59:28 +01:00
sn
soc	soc: ti: QMSS: Fix usage of irq_set_affinity_hint	2018-11-02 11:22:09 -07:00
soundwire
spi	- New Drivers	2018-10-25 06:19:15 -07:00
spmi
ssb
staging	media: dm365_ipipeif: better annotate a fall though	2018-11-06 06:58:07 -05:00
target	scsi: target/core: Avoid that a kernel oops is triggered when COMPARE AND WRITE fails	2018-11-05 22:16:00 -05:00
tc
tee
thermal	Merge branch 'next' of git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux	2018-10-31 11:28:12 -07:00
thunderbolt
tty	TTY/Serial fixes for 4.20-rc2	2018-11-10 13:32:14 -06:00
uio	uio: Fix an Oops on load	2018-11-11 09:21:46 -08:00
usb	USB fixes for 4.20-rc4	2018-11-22 08:39:29 -08:00
uwb
vfio	VFIO updates for v4.20	2018-10-31 11:01:38 -07:00
vhost	virtio, vhost: fixes, tweaks	2018-11-01 14:42:49 -07:00
video	fbdev changes for v4.20:	2018-10-31 11:41:37 -07:00
virt
virtio	virtio-balloon: VIRTIO_BALLOON_F_PAGE_POISON	2018-10-24 20:57:55 -04:00
visorbus
vlynq
vme
w1
watchdog	watchdog: ts4800: release syscon device node in ts4800_wdt_probe()	2018-10-22 10:16:28 +02:00
xen	xen: fixes for 4.20-rc2	2018-11-10 08:58:48 -06:00
zorro
Kconfig
Makefile