Steven Rostedt (Red Hat) 6c8465a82a x86/tlb/trace: Do not trace on CPU that is offline ... When taking a CPU down for suspend and resume, a tracepoint may be called when the CPU has been designated offline. As tracepoints require RCU for protection, they must not be called if the current CPU is offline. Unfortunately, trace_tlb_flush() is called in this scenario as was noted by LOCKDEP: ... Disabling non-boot CPUs ... intel_pstate CPU 1 exiting =============================== smpboot: CPU 1 didn't die... [ INFO: suspicious RCU usage. ] 3.19.0-rc7-next-20150204.1-iniza-small #1 Not tainted ------------------------------- include/trace/events/tlb.h:35 suspicious rcu_dereference_check() usage! other info that might help us debug this: RCU used illegally from offline CPU! rcu_scheduler_active = 1, debug_locks = 0 no locks held by swapper/1/0. stack backtrace: CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.19.0-rc7-next-20150204.1-iniza-small #1 Hardware name: SAMSUNG ELECTRONICS CO., LTD. 530U3BI/530U4BI/530U4BH/530U3BI/530U4BI/530U4BH, BIOS 13XK 03/28/2013 0000000000000001 ffff88011a44fe18 ffffffff817e370d 0000000000000011 ffff88011a448290 ffff88011a44fe48 ffffffff810d6847 ffff8800c66b9600 0000000000000001 ffff88011a44c000 ffffffff81cb3900 ffff88011a44fe78 Call Trace: [<ffffffff817e370d>] dump_stack+0x4c/0x65 [<ffffffff810d6847>] lockdep_rcu_suspicious+0xe7/0x120 [<ffffffff810b71a5>] idle_task_exit+0x205/0x2c0 [<ffffffff81054c4e>] play_dead_common+0xe/0x50 [<ffffffff81054ca5>] native_play_dead+0x15/0x140 [<ffffffff8102963f>] arch_cpu_idle_dead+0xf/0x20 [<ffffffff810cd89e>] cpu_startup_entry+0x37e/0x580 [<ffffffff81053e20>] start_secondary+0x140/0x150 intel_pstate CPU 2 exiting ... By converting the tlb_flush tracepoint to a TRACE_EVENT_CONDITION where the condition is cpu_online(smp_processor_id()), we can avoid calling RCU protected code when the CPU is offline. Link: http://lkml.kernel.org/r/CA+icZUUGiGDoL5NU8RuxKzFjoLjEKRtUWx=JB8B9a0EQv-eGzQ@mail.gmail.com Cc: stable@vger.kernel.org # 3.17+ Fixes: d17d8f9ded "x86/mm: Add tracepoints for TLB flushes" Reported-by: Sedat Dilek <sedat.dilek@gmail.com> Tested-by: Sedat Dilek <sedat.dilek@gmail.com> Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Acked-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com> Acked-by: Dave Hansen <dave@sr71.net> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>		2015-02-07 19:34:55 -05:00
..
acpi	Merge branches 'acpi-scan', 'acpi-utils' and 'acpi-pm'	2014-12-18 18:42:56 +01:00
asm-generic	ARM: SoC/iommu configuration for 3.19	2014-12-16 14:53:01 -08:00
clocksource
crypto	crypto: af_alg - add user space interface for AEAD	2014-12-05 23:56:55 +08:00
drm	Revert "drm/gem: Warn on illegal use of the dumb buffer interface v2"	2014-12-24 13:13:22 +10:00
dt-bindings	Merge branch 'fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal into thermal-soc	2014-12-21 22:49:12 +08:00
keys
kvm	arm/arm64: KVM: Require in-kernel vgic for the arch timers	2014-12-15 11:50:42 +01:00
linux	tracing: Add condition check to RCU lockdep checks	2015-02-07 19:34:25 -05:00
math-emu
media	[media] media: v4l2-image-sizes.h: correct the SVGA height definition	2014-12-04 13:56:56 -02:00
memory
misc
net	netlink/genetlink: pass network namespace to bind/unbind	2014-12-27 03:07:50 -05:00
pcmcia
ras
rdma	IB/core: Implement support for MMU notifiers regarding on demand paging regions	2014-12-15 18:13:36 -08:00
rxrpc
scsi	SCSI for-linus on 20141220	2014-12-20 13:42:57 -08:00
soc	Merge branch 'at91/cleanup5' into next/drivers	2014-12-08 18:29:20 +01:00
sound	ALSA: pcm: Fix kerneldoc for params_*() functions	2014-12-30 16:41:11 +01:00
target	SCSI for-linus on 20141220	2014-12-20 13:42:57 -08:00
trace	x86/tlb/trace: Do not trace on CPU that is offline	2015-02-07 19:34:55 -05:00
uapi	vhost: virtio 1.0 bugfix	2015-01-02 12:07:50 -08:00
video	OMAPDSS: Remove all references to obsolete HDMI audio callbacks	2014-12-01 11:09:59 +02:00
xen	xen/arm: introduce GNTTABOP_cache_flush	2014-12-04 12:41:54 +00:00
Kbuild