Uwe Kleine-König 9d3ac384cb platform: Provide a remove callback that returns no value ... [ Upstream commit 5c5a7680e67ba6fbbb5f4d79fa41485450c1985c ] struct platform_driver::remove returning an integer made driver authors expect that returning an error code was proper error handling. However the driver core ignores the error and continues to remove the device because there is nothing the core could do anyhow and reentering the remove callback again is only calling for trouble. So this is an source for errors typically yielding resource leaks in the error path. As there are too many platform drivers to neatly convert them all to return void in a single go, do it in several steps after this patch: a) Convert all drivers to implement .remove_new() returning void instead of .remove() returning int; b) Change struct platform_driver::remove() to return void and so make it identical to .remove_new(); c) Change all drivers back to .remove() now with the better prototype; d) drop struct platform_driver::remove_new(). While this touches all drivers eventually twice, steps a) and c) can be done one driver after another and so reduces coordination efforts immensely and simplifies review. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20221209150914.3557650-1-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Stable-dep-of: 17955aba7877 ("ASoC: fsl_micfil: Fix error handler with pm_runtime_enable") Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-24 17:32:43 +01:00
..
accessibility	tty: fix possible null-ptr-defer in spk_ttyio_release	2023-01-24 07:24:37 +01:00
acpi	ACPI: video: Remove desktops without backlight DMI quirks	2023-05-24 17:32:36 +01:00
amba
android
ata	ata: ahci: Revert "ata: ahci: Add Tiger Lake UP{3,4} AHCI controller"	2023-03-10 09:32:32 +01:00
atm	atm: idt77252: fix kmemleak when rmmod idt77252	2023-03-30 12:49:09 +02:00
auxdisplay	auxdisplay: hd44780: Fix potential memory leak in hd44780_remove()	2023-03-11 13:55:16 +01:00
base	platform: Provide a remove callback that returns no value	2023-05-24 17:32:43 +01:00
bcma
block	nbd: fix incomplete validation of ioctl arg	2023-05-24 17:32:39 +01:00
bluetooth	Bluetooth: btrtl: Add the support for RTL8851B	2023-05-24 17:32:40 +01:00
bus	bus: mhi: host: Range check CHDBOFF and ERDBOFF	2023-05-11 23:03:05 +09:00
cdrom
char	ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it	2023-05-11 23:03:26 +09:00
clk	clk: rockchip: rk3399: allow clk_cifout to force clk_cifout_src to reparent	2023-05-11 23:03:40 +09:00
clocksource	clocksource/drivers/davinci: Fix memory leak in davinci_timer_register when init fails	2023-05-11 23:03:35 +09:00
comedi
connector
counter	counter: 104-quad-8: Fix Synapse action reported for Index signals	2023-04-13 16:55:31 +02:00
cpufreq	cpufreq: use correct unit when verify cur freq	2023-05-11 23:03:16 +09:00
cpuidle	RISC-V: Align SBI probe implementation with spec	2023-05-11 23:03:04 +09:00
crypto	crypto: sun8i-ss - Fix a test in sun8i_ss_setup_ivs()	2023-05-17 11:53:40 +02:00
cxl	cxl/hdm: Fail upon detecting 0-sized decoders	2023-05-11 23:03:05 +09:00
dax	dax/kmem: Fix leak of memory-hotplug resources	2023-03-10 09:34:25 +01:00
dca
devfreq
dio
dma	dmaengine: at_xdmac: do not enable all cyclic channels	2023-05-11 23:03:37 +09:00
dma-buf	dma-buf: actually set signaling bit for private stub fences	2023-02-09 11:28:23 +01:00
edac	qcom: llcc/edac: Support polling mode for ECC handling	2023-05-17 11:53:28 +02:00
eisa
extcon
firewire	firewire: fix memory leak for payload of request subaction to IEC 61883-1 FCP region	2023-02-09 11:27:59 +01:00
firmware	irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4	2023-05-24 17:32:36 +01:00
fpga	fpga: bridge: fix kernel-doc parameter description	2023-05-11 23:03:27 +09:00
fsi	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
gnss
gpio	gpiolib: acpi: Add a ignore wakeup quirk for Clevo NL5xNU	2023-05-01 08:26:27 +09:00
gpu	drm/msm/dpu: Remove duplicate register defines from INTF	2023-05-24 17:32:43 +01:00
greybus
hid	HID: wacom: generic: Set battery quirk only when we see battery data	2023-05-24 17:32:41 +01:00
hsi
hte	hte: tegra-194: Fix off by one in tegra_hte_map_to_line_id()	2023-05-11 23:03:38 +09:00
hv	Drivers: vmbus: Check for channel allocation before looking up relids	2023-04-13 16:55:18 +02:00
hwmon	hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E	2023-05-11 23:03:16 +09:00
hwspinlock
hwtracing	coresight: etm_pmu: Set the module field	2023-05-11 23:03:29 +09:00
i2c	i2c: tegra: Fix PEC support for SMBUS block read	2023-05-17 11:53:34 +02:00
i3c
idle	Revert "cpuidle, intel_idle: Fix CPUIDLE_FLAG_IRQ_ENABLE *again*"	2023-04-06 12:10:58 +02:00
iio	iio: light: max44009: add missing OF device matching	2023-05-11 23:03:27 +09:00
infiniband	RDMA/mlx5: Use correct device num_ports when modify DC	2023-05-11 23:03:35 +09:00
input	Input: raspberrypi-ts - fix refcount leak in rpi_ts_probe	2023-05-11 23:03:35 +09:00
interconnect	interconnect: qcom: rpm: drop bogus pm domain attach	2023-05-11 23:03:28 +09:00
iommu	iommu/amd: Set page size bitmap during V2 domain allocation	2023-05-11 23:03:34 +09:00
ipack
irqchip	irqchip/gicv3: Workaround for NVIDIA erratum T241-FABRIC-4	2023-05-24 17:32:36 +01:00
isdn	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
leds	leds: tca6507: Fix error handling of using fwnode_property_read_string	2023-05-11 23:03:36 +09:00
macintosh	macintosh: via-pmu-led: requires ATA to be set	2023-05-11 23:03:31 +09:00
mailbox	mailbox: zynqmp: Fix counts of child nodes	2023-05-17 11:53:28 +02:00
mcb	mcb-pci: Reallocate memory region to avoid memory overlapping	2023-05-24 17:32:41 +01:00
md	md: fix soft lockup in status_resync	2023-05-24 17:32:38 +01:00
media	media: mediatek: vcodec: Fix potential array out-of-bounds in decoder queue_setup	2023-05-24 17:32:36 +01:00
memory	memory: tegra30-emc: fix interconnect registration race	2023-03-22 13:33:56 +01:00
memstick	memstick: r592: Fix UAF bug in r592_remove due to race condition	2023-05-24 17:32:35 +01:00
message	scsi: message: mptlan: Fix use after free bug in mptlan_remove() due to race condition	2023-05-24 17:32:37 +01:00
mfd	mfd: intel-lpss: Add Intel Meteor Lake PCH-S LPSS PCI IDs	2023-05-24 17:32:42 +01:00
misc	lkdtm/stackleak: Fix noinstr violation	2023-05-24 17:32:41 +01:00
mmc	mmc: sdhci-of-esdhc: fix quirk to ignore command inhibit for data	2023-05-11 23:03:11 +09:00
most
mtd	mtd: spi-nor: spansion: Enable JFFS2 write buffer for Infineon s25hx SEMPER flash	2023-05-17 11:53:29 +02:00
mux
net	wifi: ath11k: Fix SKB corruption in REO destination ring	2023-05-24 17:32:39 +01:00
nfc	nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition	2023-03-22 13:33:46 +01:00
ntb
nubus
nvdimm	cxl/pmem: Fix nvdimm registration races	2023-03-10 09:34:20 +01:00
nvme	nvme-fcloop: fix "inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage"	2023-05-11 23:03:22 +09:00
nvmem	nvmem: core: fix return value	2023-02-09 11:28:25 +01:00
of	of: Fix modalias string generation	2023-05-11 23:03:28 +09:00
opp	OPP: fix error checking in opp_migrate_dentry()	2023-03-10 09:33:01 +01:00
parisc	parisc: Replace regular spinlock with spin_trylock on panic path	2023-05-24 17:32:42 +01:00
parport
pci	PCI/PM: Extend D3hot delay for NVIDIA HDA controllers	2023-05-11 23:03:29 +09:00
pcmcia
peci
perf	perf/arm-cmn: Fix port detection for CMN-700	2023-05-11 23:03:16 +09:00
phy	phy: st: miphy28lp: use _poll_timeout functions for waits	2023-05-24 17:32:41 +01:00
pinctrl	pinctrl-bcm2835.c: fix race condition when setting gpio dir	2023-05-11 23:03:37 +09:00
platform	platform/x86: hp-wmi: add micmute to hp_wmi_keymap struct	2023-05-24 17:32:42 +01:00
pnp
power	power: supply: rk817: Fix low SOC bugs	2023-05-11 23:03:34 +09:00
powercap	powercap: fix possible name leak in powercap_register_zone()	2023-03-10 09:32:56 +01:00
pps
ps3
ptp	ptp_qoriq: fix memory leak in probe()	2023-04-06 12:10:44 +02:00
pwm	pwm: mtk-disp: Configure double buffering before reading in .get_state()	2023-05-11 23:03:37 +09:00
rapidio
ras
regulator	regulator: stm32-pwr: fix of_iomap leak	2023-05-11 23:03:16 +09:00
remoteproc	remoteproc: stm32_rproc: Add mutex protection for workqueue	2023-05-24 17:32:35 +01:00
reset	reset: uniphier-glue: Fix possible null-ptr-deref	2023-02-01 08:34:05 +01:00
rpmsg	rpmsg: glink: Propagate TX failures in intentless mode as well	2023-05-11 23:03:16 +09:00
rtc	rtc: k3: handle errors while enabling wake irq	2023-05-11 23:03:33 +09:00
s390	s390/dasd: fix hanging blockdevice after request requeue	2023-05-11 23:03:40 +09:00
sbus
scsi	scsi: lpfc: Correct used_rpi count when devloss tmo fires with no recovery	2023-05-24 17:32:37 +01:00
sh
siox
slimbus
soc	soc: qcom: llcc: Do not create EDAC platform device on SDM845	2023-05-17 11:53:28 +02:00
soundwire	soundwire: bus: Fix unbalanced pm_runtime_put() causing usage count underflow	2023-05-24 17:32:42 +01:00
spi	spi: spi-imx: fix MX51_ECSPI_* macros when cs > 3	2023-05-24 17:32:40 +01:00
spmi	spmi: Add a check for remove callback when removing a SPMI driver	2023-05-11 23:03:31 +09:00
ssb
staging	staging: axis-fifo: initialize timeouts in init only	2023-05-24 17:32:40 +01:00
target	scsi: target: iscsit: Free cmds before session free	2023-05-24 17:32:37 +01:00
tc
tee	tee: amdtee: fix race condition in amdtee_open_session	2023-03-30 12:49:29 +02:00
thermal	thermal/drivers/mediatek: Use devm_of_iomap to avoid resource leak in mtk_thermal_probe	2023-05-11 23:03:37 +09:00
thunderbolt	thunderbolt: Use correct type in tb_port_is_clx_enabled() prototype	2023-05-11 23:03:41 +09:00
tty	serial: 8250: Reinit port->pm on port specific driver unbind	2023-05-24 17:32:41 +01:00
ufs	scsi: ufs: ufs-pci: Add support for Intel Lunar Lake	2023-05-24 17:32:37 +01:00
uio
usb	usb: typec: tcpm: fix multiple times discover svids error	2023-05-24 17:32:41 +01:00
vdpa	vp_vdpa: fix the crash in hot unplug with vp_vdpa	2023-03-22 13:34:03 +01:00
vfio	vfio/type1: restore locked_vm	2023-03-10 09:34:32 +01:00
vhost	vhost_vdpa: fix unmap process in no-batch mode	2023-05-11 23:03:41 +09:00
video	fbdev: arcfb: Fix error handling in arcfb_probe()	2023-05-24 17:32:33 +01:00
virt	virt/coco/sev-guest: Double-buffer messages	2023-05-11 23:03:10 +09:00
virtio	virtio_ring: don't update event idx on get_buf	2023-05-11 23:03:31 +09:00
vlynq
w1	w1: fix WARNING after calling w1_process()	2023-02-01 08:34:26 +01:00
watchdog	watchdog: dw_wdt: Fix the error handling path of dw_wdt_drv_probe()	2023-05-17 11:53:34 +02:00
xen	ACPI: processor: Fix evaluating _PDC method when running as Xen dom0	2023-05-11 23:03:11 +09:00
zorro
Kconfig
Makefile