Dongliang Mu 0c80bef0b7 fs: hfsplus: fix UAF issue in hfsplus_put_super ... commit 07db5e247ab5858439b14dd7cc1fe538b9efcf32 upstream. The current hfsplus_put_super first calls hfs_btree_close on sbi->ext_tree, then invokes iput on sbi->hidden_dir, resulting in an use-after-free issue in hfsplus_release_folio. As shown in hfsplus_fill_super, the error handling code also calls iput before hfs_btree_close. To fix this error, we move all iput calls before hfsplus_btree_close. Note that this patch is tested on Syzbot. Link: https://lkml.kernel.org/r/20230226124948.3175736-1-mudongliangabcd@gmail.com Reported-by: syzbot+57e3e98f7e3b80f64d56@syzkaller.appspotmail.com Tested-by: Dongliang Mu <mudongliangabcd@gmail.com> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com> Cc: Bart Van Assche <bvanassche@acm.org> Cc: Jens Axboe <axboe@kernel.dk> Cc: Muchun Song <songmuchun@bytedance.com> Cc: Roman Gushchin <roman.gushchin@linux.dev> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2023-03-10 09:34:07 +01:00
..
attributes.c
bfind.c
bitmap.c	hfsplus: convert kmap() to kmap_local_page() in bitmap.c	2022-09-11 21:55:04 -07:00
bnode.c	hfsplus: convert kmap() to kmap_local_page() in bnode.c	2022-09-11 21:55:04 -07:00
brec.c
btree.c	hfsplus: convert kmap() to kmap_local_page() in btree.c	2022-09-11 21:55:05 -07:00
catalog.c
dir.c
extents.c	hfsplus: Call hfsplus_write_begin() and generic_write_end() directly	2022-05-08 14:45:56 -04:00
hfsplus_fs.h	hfsplus: fix bug causing custom uid and gid being unable to be assigned with mount	2023-01-04 11:28:59 +01:00
hfsplus_raw.h
inode.c	hfsplus: fix bug causing custom uid and gid being unable to be assigned with mount	2023-01-04 11:28:59 +01:00
ioctl.c
Kconfig
Makefile
options.c	hfsplus: fix bug causing custom uid and gid being unable to be assigned with mount	2023-01-04 11:28:59 +01:00
part_tbl.c	fs/hfsplus: Use the enum req_op and blk_opf_t types	2022-07-14 12:14:32 -06:00
super.c	fs: hfsplus: fix UAF issue in hfsplus_put_super	2023-03-10 09:34:07 +01:00
tables.c
unicode.c
wrapper.c	fs/hfsplus: Use the enum req_op and blk_opf_t types	2022-07-14 12:14:32 -06:00
xattr.c
xattr.h
xattr_security.c
xattr_trusted.c
xattr_user.c