The binder_update_page_range() function performs both allocation and freeing of binder pages. However, these two operations are unrelated and have no common logic. In fact, when a free operation is requested, the allocation logic is skipped entirely. This behavior makes the error path unnecessarily complex. To improve readability of the code, this patch splits the allocation and freeing operations into separate functions. No functional changes are introduced by this patch. Reviewed-by: Alice Ryhl <aliceryhl@google.com> Signed-off-by: Carlos Llamas <cmllamas@google.com> Link: https://lore.kernel.org/r/20231201172212.1813387-11-cmllamas@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Bug: 254650075 (cherry picked from commit 0d35bf3bf2da8d43fd12fea7699dc936999bf96e) Change-Id: Iaf64f94564d2017c4633f2421c15b0bdee914738 Signed-off-by: Carlos Llamas <cmllamas@google.com> |
||
|---|---|---|
| .. | ||
| android_debug_symbols.c | ||
| binder.c | ||
| binder_alloc.c | ||
| binder_alloc.h | ||
| binder_alloc_selftest.c | ||
| binder_internal.h | ||
| binder_trace.h | ||
| binderfs.c | ||
| debug_kinfo.c | ||
| debug_kinfo.h | ||
| Kconfig | ||
| Makefile | ||
| vendor_hooks.c | ||