From 03f83f513de3f32a4539875d64e8511fbcfdaeb4 Mon Sep 17 00:00:00 2001
From: Ross Brunton <bruntonross@protonmail.com>
Date: Sat, 4 Oct 2025 03:20:39 +0000
Subject: [PATCH] vscode: get paths from product.json

The VSCode packages contain a product.json which is used to determine
the extension and config dirs. When the package name is not known,
this change parses this file (using IFD) (which may appear in a few
places) and uses that to generate the paths.

This hopefully allows more VSCode derivatives to "just work" without
Home Manager updates.

Co-authored-by: andre4ik3 <andre4ik3@fastmail.com>
---
 modules/programs/vscode/default.nix | 100 +++++++++++++++++++++-------
 1 file changed, 76 insertions(+), 24 deletions(-)

diff --git a/modules/programs/vscode/default.nix b/modules/programs/vscode/default.nix
index ebc62cd72..4eba83784 100644
--- a/modules/programs/vscode/default.nix
+++ b/modules/programs/vscode/default.nix
@@ -22,29 +22,58 @@ let
 
   jsonFormat = pkgs.formats.json { };
 
-  configDir =
-    {
-      "vscode" = "Code";
-      "vscode-insiders" = "Code - Insiders";
-      "vscodium" = "VSCodium";
-      "openvscode-server" = "OpenVSCode Server";
-      "windsurf" = "Windsurf";
-      "cursor" = "Cursor";
-      "kiro" = "Kiro";
-    }
-    .${vscodePname};
+  productInfoPath =
+    if
+      lib.pathExists "${cfg.package}/Applications/${
+        cfg.package.passthru.longName or "Code"
+      }.app/Contents/Resources/app/product.json"
+    then
+      "${cfg.package}/Applications/${
+        cfg.package.passthru.longName or "Code"
+      }.app/Contents/Resources/app/product.json"
+    else if lib.pathExists "${cfg.package}/lib/vscode/resources/app/product.json" then
+      # Visual Studio Code, VSCodium, Windsurf, Cursor
+      "${cfg.package}/lib/vscode/resources/app/product.json"
+    else
+      # OpenVSCode Server
+      "${cfg.package}/product.json";
 
-  extensionDir =
-    {
-      "vscode" = "vscode";
-      "vscode-insiders" = "vscode-insiders";
-      "vscodium" = "vscode-oss";
-      "openvscode-server" = "openvscode-server";
-      "windsurf" = "windsurf";
-      "cursor" = "cursor";
-      "kiro" = "kiro";
-    }
-    .${vscodePname};
+  productInfo = lib.importJSON productInfoPath;
+
+  # Use preset names for known products to avoid IFD loading it from product.json
+  knownProducts = {
+    cursor = {
+      dataFolderName = ".cursor";
+      nameShort = "Cursor";
+    };
+    kiro = {
+      dataFolderName = ".kiro";
+      nameShort = "Kiro";
+    };
+    openvscode-server = {
+      dataFolderName = ".openvscode-server";
+      nameShort = "OpenVSCode Server";
+    };
+    vscode = {
+      dataFolderName = ".vscode";
+      nameShort = "Code";
+    };
+    vscode-insiders = {
+      dataFolderName = ".vscode-insiders";
+      nameShort = "Code - Insiders";
+    };
+    vscodium = {
+      dataFolderName = ".vscode-oss";
+      nameShort = "VSCodium";
+    };
+    windsurf = {
+      dataFolderName = ".windsurf";
+      nameShort = "Windsurf";
+    };
+  };
+
+  configDir = cfg.nameShort;
+  extensionDir = cfg.dataFolderName;
 
   userDir =
     if pkgs.stdenv.hostPlatform.isDarwin then
@@ -62,8 +91,7 @@ let
 
   snippetDir = name: "${userDir}/${optionalString (name != "default") "profiles/${name}/"}snippets";
 
-  # TODO: On Darwin where are the extensions?
-  extensionPath = ".${extensionDir}/extensions";
+  extensionPath = "${extensionDir}/extensions";
 
   extensionJson = ext: pkgs.vscode-utils.toExtensionJson ext;
   extensionJsonFile =
@@ -319,6 +347,30 @@ in
       '';
     };
 
+    nameShort = mkOption {
+      type = types.str;
+      default = knownProducts.${vscodePname}.nameShort or productInfo.nameShort;
+      defaultText = "(derived from product.json)";
+      example = "MyCoolVSCodeFork";
+      description = ''
+        Override for package "short name", used for generating configuration.
+
+        This should match the `shortName` field in the package's product.json. If `null`, then searches common locations for a product.json and uses the value from there.
+      '';
+    };
+
+    dataFolderName = mkOption {
+      type = types.str;
+      default = knownProducts.${vscodePname}.dataFolderName or productInfo.dataFolderName;
+      defaultText = "(derived from product.json)";
+      example = ".cool-vscode";
+      description = ''
+        Override for extensions directory.
+
+        This should match the `dataFolderName` field in the package's product.json. If `null`, then searches common locations for a product.json and uses the value from there.
+      '';
+    };
+
     profiles = mkOption {
       type = types.attrsOf profileType;
       default = { };