From 0f355844e54e4c70906b1ef5cc35a0047d666c04 Mon Sep 17 00:00:00 2001
From: Austin Horstman <khaneliman12@gmail.com>
Date: Wed, 18 Jun 2025 14:39:32 -0500
Subject: [PATCH] tests/firefox: fix bookmarks test (#7292)

Not run in CI so didn't notice. We had a shared file. But, now attrset
and list differ in what they can generate. Separate the expected test
files.

Signed-off-by: Austin Horstman <khaneliman12@gmail.com>
---
 .../firefox/profiles/bookmarks/attrset.nix    |  2 +-
 .../firefox/profiles/bookmarks/default.nix    |  2 +-
 .../bookmarks/expected-bookmarks-attrset.html | 25 +++++++++++++++++++
 ...arks.html => expected-bookmarks-list.html} |  0
 4 files changed, 27 insertions(+), 2 deletions(-)
 create mode 100644 tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-attrset.html
 rename tests/modules/programs/firefox/profiles/bookmarks/{expected-bookmarks.html => expected-bookmarks-list.html} (100%)

diff --git a/tests/modules/programs/firefox/profiles/bookmarks/attrset.nix b/tests/modules/programs/firefox/profiles/bookmarks/attrset.nix
index 2168e467f..bd157a0a6 100644
--- a/tests/modules/programs/firefox/profiles/bookmarks/attrset.nix
+++ b/tests/modules/programs/firefox/profiles/bookmarks/attrset.nix
@@ -86,7 +86,7 @@ in
 
         assertFileContent \
           $bookmarksFile \
-          ${./expected-bookmarks.html}
+          ${./expected-bookmarks-attrset.html}
       '';
     }
   );
diff --git a/tests/modules/programs/firefox/profiles/bookmarks/default.nix b/tests/modules/programs/firefox/profiles/bookmarks/default.nix
index 19655368f..4fd5f88cc 100644
--- a/tests/modules/programs/firefox/profiles/bookmarks/default.nix
+++ b/tests/modules/programs/firefox/profiles/bookmarks/default.nix
@@ -94,7 +94,7 @@ in
 
         assertFileContent \
           $bookmarksFile \
-          ${./expected-bookmarks.html}
+          ${./expected-bookmarks-list.html}
       '';
     }
   );
diff --git a/tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-attrset.html b/tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-attrset.html
new file mode 100644
index 000000000..4f22e86cc
--- /dev/null
+++ b/tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-attrset.html
@@ -0,0 +1,25 @@
+<!DOCTYPE NETSCAPE-Bookmark-file-1>
+<!-- This is an automatically generated file.
+  It will be read and overwritten.
+  DO NOT EDIT! -->
+<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=UTF-8">
+<TITLE>Bookmarks</TITLE>
+<H1>Bookmarks Menu</H1>
+<DL><p>
+  <DT><H3 ADD_DATE="1" LAST_MODIFIED="1" PERSONAL_TOOLBAR_FOLDER="true">Bookmarks Toolbar</H3>
+  <DL><p>
+    <DT><A HREF="https://wiki.nixos.org/wiki/Home_Manager" ADD_DATE="1" LAST_MODIFIED="1">Home Manager</A>
+  </DL><p>
+  <DT><A HREF="https://www.kernel.org" ADD_DATE="1" LAST_MODIFIED="1">kernel.org</A>
+  <DT><H3 ADD_DATE="1" LAST_MODIFIED="1">Nix sites</H3>
+  <DL><p>
+    <DT><A HREF="https://nixos.org/" ADD_DATE="1" LAST_MODIFIED="1">homepage</A>
+    <DT><A HREF="https://wiki.nixos.org/" ADD_DATE="1" LAST_MODIFIED="1" TAGS="wiki,nix">wiki</A>
+    <DT><H3 ADD_DATE="1" LAST_MODIFIED="1">Nix sites</H3>
+    <DL><p>
+      <DT><A HREF="https://nixos.org/" ADD_DATE="1" LAST_MODIFIED="1">homepage</A>
+      <DT><A HREF="https://wiki.nixos.org/" ADD_DATE="1" LAST_MODIFIED="1">wiki</A>
+    </DL><p>
+  </DL><p>
+  <DT><A HREF="https://en.wikipedia.org/wiki/Special:Search?search=%s&amp;go=Go" ADD_DATE="1" LAST_MODIFIED="1" SHORTCUTURL="wiki" TAGS="wiki">wikipedia</A>
+</DL>
diff --git a/tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks.html b/tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-list.html
similarity index 100%
rename from tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks.html
rename to tests/modules/programs/firefox/profiles/bookmarks/expected-bookmarks-list.html