nix-community/home-manager
1
0
Fork 0
mirror of https://github.com/nix-community/home-manager.git synced 2025-11-08 11:36:05 +01:00
Code Activity

launchd+targets/darwin: Escape XML in plists (#7356)

Browse source 
This patch updates all usage of toPlist such that it escapes any strings
in the final output.

The motication for this change is to avoid confusion when end-users of
home-manager's APIs are not aware that the option values they set end up
being passed un-escaped to XML files.

BREAKING CHANGE: Consumers doing manual escaping will now be doubly escaped.

Co-authored-by: Linnnus <linnnus@users.noreply.github.com>
This commit is contained in:
lignus 2025-08-09 18:22:08 +02:00 • committed by GitHub
parent cc2fa2331a
commit 3ec1cd9a07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 35 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
modules/targets/darwin/keybindings.nix
View file

@ -8,7 +8,9 @@
let
cfg = config.targets.darwin;
homeDir = config.home.homeDirectory;
confFile = pkgs.writeText "DefaultKeybinding.dict" (lib.generators.toPlist { } cfg.keybindings);
confFile = pkgs.writeText "DefaultKeybinding.dict" (
lib.generators.toPlist { escape = true; } cfg.keybindings
);
in
{
options.targets.darwin.keybindings = lib.mkOption {

3
modules/targets/darwin/user-defaults/default.nix
View file

@ -11,7 +11,8 @@ let
mkActivationCmds =
isLocal: settings:
let
toDefaultsFile = domain: attrs: pkgs.writeText "${domain}.plist" (lib.generators.toPlist { } attrs);
toDefaultsFile =
domain: attrs: pkgs.writeText "${domain}.plist" (lib.generators.toPlist { escape = true; } attrs);
cliFlags = lib.optionalString isLocal "-currentHost";