From 7f619d2a72061c24c5ef184aa9f89a4b6c6a2e70 Mon Sep 17 00:00:00 2001
From: Leon <99900077+leon-erd@users.noreply.github.com>
Date: Thu, 30 Oct 2025 20:53:43 +0100
Subject: [PATCH] aerospace: remove broken on-window-detected option

---
 modules/programs/aerospace.nix                | 77 -------------------
 .../aerospace/colemak-settings-expected.toml  |  1 -
 .../programs/aerospace/settings-expected.toml |  1 -
 3 files changed, 79 deletions(-)

diff --git a/modules/programs/aerospace.nix b/modules/programs/aerospace.nix
index 1b5e4ab92..958f69277 100644
--- a/modules/programs/aerospace.nix
+++ b/modules/programs/aerospace.nix
@@ -151,83 +151,6 @@ in
             default = "auto";
             description = "Default orientation for the root container.";
           };
-          on-window-detected = mkOption {
-            type = types.listOf (
-              types.submodule {
-                options = {
-                  "if" = mkOption {
-                    type = types.submodule {
-                      options = {
-                        app-id = mkOption {
-                          type = with types; nullOr str;
-                          default = null;
-                          description = "The application ID to match (optional).";
-                        };
-                        workspace = mkOption {
-                          type = with types; nullOr str;
-                          default = null;
-                          description = "The workspace name to match (optional).";
-                        };
-                        window-title-regex-substring = mkOption {
-                          type = with types; nullOr str;
-                          default = null;
-                          description = "Substring to match in the window title (optional).";
-                        };
-                        app-name-regex-substring = mkOption {
-                          type = with types; nullOr str;
-                          default = null;
-                          description = "Regex substring to match the app name (optional).";
-                        };
-                        during-aerospace-startup = mkOption {
-                          type = with types; nullOr bool;
-                          default = null;
-                          description = "Whether to match during aerospace startup (optional).";
-                        };
-                      };
-                    };
-                    default = { };
-                    description = "Conditions for detecting a window.";
-                  };
-                  check-further-callbacks = mkOption {
-                    type = with types; nullOr bool;
-                    default = null;
-                    description = "Whether to check further callbacks after this rule (optional).";
-                  };
-                  run = mkOption {
-                    type =
-                      with types;
-                      oneOf [
-                        str
-                        (listOf str)
-                      ];
-                    example = [
-                      "move-node-to-workspace m"
-                      "resize-node"
-                    ];
-                    description = "Commands to execute when the conditions match (required).";
-                  };
-                };
-              }
-            );
-            default = [ ];
-            example = [
-              {
-                "if" = {
-                  app-id = "Another.Cool.App";
-                  workspace = "cool-workspace";
-                  window-title-regex-substring = "Title";
-                  app-name-regex-substring = "CoolApp";
-                  during-aerospace-startup = false;
-                };
-                check-further-callbacks = false;
-                run = [
-                  "move-node-to-workspace m"
-                  "resize-node"
-                ];
-              }
-            ];
-            description = "Commands to run every time a new window is detected with optional conditions.";
-          };
           workspace-to-monitor-force-assignment = mkOption {
             type =
               with types;
diff --git a/tests/modules/programs/aerospace/colemak-settings-expected.toml b/tests/modules/programs/aerospace/colemak-settings-expected.toml
index 1ed14e998..e8e97b182 100644
--- a/tests/modules/programs/aerospace/colemak-settings-expected.toml
+++ b/tests/modules/programs/aerospace/colemak-settings-expected.toml
@@ -7,7 +7,6 @@ enable-normalization-opposite-orientation-for-nested-containers = true
 exec-on-workspace-change = []
 on-focus-changed = []
 on-focused-monitor-changed = ["move-mouse monitor-lazy-center"]
-on-window-detected = []
 
 [gaps.outer]
 bottom = 8
diff --git a/tests/modules/programs/aerospace/settings-expected.toml b/tests/modules/programs/aerospace/settings-expected.toml
index b46ebad41..07f882648 100644
--- a/tests/modules/programs/aerospace/settings-expected.toml
+++ b/tests/modules/programs/aerospace/settings-expected.toml
@@ -8,7 +8,6 @@ enable-normalization-opposite-orientation-for-nested-containers = true
 exec-on-workspace-change = []
 on-focus-changed = []
 on-focused-monitor-changed = ["move-mouse monitor-lazy-center"]
-on-window-detected = []
 start-at-login = false
 
 [gaps.outer]