From 342a6b6c73fc0dddab4ff0ad40874308e19758c1 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Thu, 23 Oct 2025 10:26:03 +0200
Subject: [PATCH] plugins/coq-thirdparty: migrate to mkNeovimPlugin

---
 flake/dev/list-plugins/list-plugins.py        |  4 +-
 plugins/by-name/coq-thirdparty/default.nix    | 94 ++++++-------------
 .../by-name/coq-thirdparty/default.nix        |  3 +-
 3 files changed, 30 insertions(+), 71 deletions(-)

diff --git a/flake/dev/list-plugins/list-plugins.py b/flake/dev/list-plugins/list-plugins.py
index d8f25444..25069edd 100755
--- a/flake/dev/list-plugins/list-plugins.py
+++ b/flake/dev/list-plugins/list-plugins.py
@@ -69,9 +69,7 @@ KNOWN_PATHS: dict[
         Kind,  # Vim / Neovim / misc
         bool,  # Has deprecation warnings
     ],
-] = {
-    "plugins/by-name/coq-thirdparty/default.nix": (State.OLD, Kind.NEOVIM, False),
-}
+] = {}
 for telescope_extension_name, has_depr_warnings in {
     "advanced-git-search": False,
     "file-browser": True,
diff --git a/plugins/by-name/coq-thirdparty/default.nix b/plugins/by-name/coq-thirdparty/default.nix
index bb8d5ed3..3f5c7303 100644
--- a/plugins/by-name/coq-thirdparty/default.nix
+++ b/plugins/by-name/coq-thirdparty/default.nix
@@ -1,71 +1,33 @@
-{
-  lib,
-  config,
-  pkgs,
-  ...
-}:
-with lib;
-let
-  cfg = config.plugins.coq-thirdparty;
-in
-{
-  options.plugins.coq-thirdparty = {
-    enable = mkEnableOption "coq-thirdparty";
+{ lib, ... }:
+lib.nixvim.plugins.mkNeovimPlugin {
+  name = "coq-thirdparty";
+  maintainers = [ lib.maintainers.GaetanLepage ];
 
-    package = lib.mkPackageOption pkgs "coq-thirdparty" {
-      default = [
-        "vimPlugins"
+  # The lua setup call is: `require('coq_3p')({...})`
+  moduleName = "coq_3p";
+  setup = "";
+
+  # TODO: Added 2025-10-24, remove after 26.05
+  imports =
+    let
+      basePluginPath = [
+        "plugins"
         "coq-thirdparty"
       ];
-    };
+    in
+    [
+      (lib.mkRenamedOptionModule (basePluginPath ++ [ "sources" ]) (basePluginPath ++ [ "settings" ]))
+    ];
 
-    sources = mkOption {
-      type = types.listOf (
-        types.submodule {
-          freeformType = types.attrs;
-
-          options = {
-            src = mkOption {
-              type = types.str;
-              description = "The name of the source";
-            };
-
-            short_name = mkOption {
-              type = types.nullOr types.str;
-              description = ''
-                A short name for the source.
-                If not specified, it is uppercase `src`.
-              '';
-              example = "nLUA";
-              default = null;
-            };
-          };
-        }
-      );
-      description = ''
-        List of sources.
-        Each source is a free-form type, so additional settings like `accept_key` may be specified even if they are not declared by nixvim.
-      '';
-      default = [ ];
-      example = [
-        {
-          src = "nvimlua";
-          short_name = "nLUA";
-        }
-        {
-          src = "vimtex";
-          short_name = "vTEX";
-        }
-        { src = "demo"; }
-      ];
-    };
-  };
-
-  config = mkIf cfg.enable {
-    extraPlugins = [ cfg.package ];
-
-    extraConfigLua = ''
-      require('coq_3p')(${lib.nixvim.toLuaObject cfg.sources})
-    '';
-  };
+  settingsExample = [
+    {
+      src = "nvimlua";
+      short_name = "nLUA";
+    }
+    {
+      src = "vimtex";
+      short_name = "vTEX";
+    }
+    { src = "demo"; }
+  ];
 }
diff --git a/tests/test-sources/plugins/by-name/coq-thirdparty/default.nix b/tests/test-sources/plugins/by-name/coq-thirdparty/default.nix
index e89709b8..a081b868 100644
--- a/tests/test-sources/plugins/by-name/coq-thirdparty/default.nix
+++ b/tests/test-sources/plugins/by-name/coq-thirdparty/default.nix
@@ -1,5 +1,4 @@
 {
-  # Empty configuration
   empty = {
     plugins.coq-thirdparty.enable = true;
   };
@@ -8,7 +7,7 @@
     plugins.coq-thirdparty = {
       enable = true;
 
-      sources = [
+      settings = [
         {
           src = "nvimlua";
           short_name = "nLUA";