From baa99016bc76881762540cedb7b1ed46d9f91e56 Mon Sep 17 00:00:00 2001 From: saygo-png Date: Sat, 25 Oct 2025 01:08:31 +0200 Subject: [PATCH] treewide: remove outdated broken package markings Signed-off-by: saygo-png --- .../conform-nvim/formatter-packages.nix | 5 +--- tests/all-package-defaults.nix | 26 ------------------- tests/lsp-servers.nix | 10 ------- .../plugins/by-name/efmls-configs/default.nix | 17 +----------- .../plugins/by-name/rzls/default.nix | 8 ------ .../plugins/by-name/vimtex/default.nix | 13 +++------- 6 files changed, 5 insertions(+), 74 deletions(-) diff --git a/plugins/by-name/conform-nvim/formatter-packages.nix b/plugins/by-name/conform-nvim/formatter-packages.nix index 83cbb59d..2fc6865b 100644 --- a/plugins/by-name/conform-nvim/formatter-packages.nix +++ b/plugins/by-name/conform-nvim/formatter-packages.nix @@ -25,14 +25,10 @@ rec { # 2025-09-13 build failure inko = sType.broken; - # 2025-09-13 build failure - commitmsgfmt = sType.broken; # 2025-09-17 build failure gci = sType.broken; # 2025-10-08 build failure (haskellPackages.hindent) hindent = sType.broken; - # 2025-10-12 build failure (luaformatter depends on broken antlr-runtime-cpp) - lua-format = sType.broken; format-queries = null; # Uses neovim itself init = null; # Internal thingamajig @@ -118,6 +114,7 @@ rec { js_beautify = nodePackages.js-beautify; jsonnetfmt = jsonnet; inherit (texlive.pkgs) latexindent; + lua-format = luaformatter; mago_format = mago; mago_lint = mago; markdownlint = markdownlint-cli; diff --git a/tests/all-package-defaults.nix b/tests/all-package-defaults.nix index 6bac7231..5dcdbf4a 100644 --- a/tests/all-package-defaults.nix +++ b/tests/all-package-defaults.nix @@ -17,20 +17,6 @@ let # build failure (fixed in https://github.com/NixOS/nixpkgs/pull/455238) "yamlfix" - # TODO: 2025-10-03 - # Transient dependency `vmr` has a build failure - # https://github.com/NixOS/nixpkgs/issues/431811 - "roslyn-ls" - - # 2025-07-25 python313Packages.lsp-tree-sitter is marked as broken - "autotools-language-server" - - # 2025-04-01 php-cs-fixer is marked as broken - "php-cs-fixer" - - # 2025-10-12 build failure (luaformatter depends on broken antlr-runtime-cpp) - "luaformatter" - # 2025-10-12 dependency mbedtls is marked as insecure "haxe" ] @@ -90,15 +76,11 @@ let # 2025-09-27 build failure "open-policy-agent" - # 2025-09-26 build failure - "verilator" - # 2025-09-08 build failure "mint" # Marked as broken "akku-scheme-langserver" - "muon" "rubyfmt" "wl-clipboard" # wayland ] @@ -127,10 +109,6 @@ let # 2025-06-24 build failure "gleam" - # 2024-01-04 build failure - "texlive-combined-medium" - "texlive" - # 2025-09-16 zig/zig-hook is marked as broken # https://github.com/NixOS/nixpkgs/commit/bc725b12b2595951a3f4b112d59716d30b41001a "zf" @@ -150,10 +128,6 @@ let # 2025-09-08, build failure # https://github.com/NixOS/nixpkgs/pull/441058 "verible" - - # 2025-09-08 ttfautohint hangs forever - "texlive-combined-medium" - "texlive" ]; isEnabled = p: !(builtins.elem (lib.getName p) disabledTests); diff --git a/tests/lsp-servers.nix b/tests/lsp-servers.nix index cec33dc1..1924008d 100644 --- a/tests/lsp-servers.nix +++ b/tests/lsp-servers.nix @@ -37,18 +37,8 @@ let let disabled = [ - # TODO: 2025-10-03 - # Transient dependency `vmr` has a build failure - # https://github.com/NixOS/nixpkgs/issues/431811 - "roslyn_ls" - - # TODO: 2025-07-25 python313Packages.lsp-tree-sitter marked as broken - "autotools_ls" - # TODO: 2025-07-25 build failure "mint" - "nextls" - "ts_query_ls" # DEPRECATED SERVERS # See https://github.com/neovim/nvim-lspconfig/blob/master/lua/lspconfig.lua diff --git a/tests/test-sources/plugins/by-name/efmls-configs/default.nix b/tests/test-sources/plugins/by-name/efmls-configs/default.nix index b04e2002..dcd45365 100644 --- a/tests/test-sources/plugins/by-name/efmls-configs/default.nix +++ b/tests/test-sources/plugins/by-name/efmls-configs/default.nix @@ -21,22 +21,7 @@ "JSON" ]; - brokenTools = [ - # 2025-10-12 build failure (luaformatter depends on broken antlr-runtime-cpp) - "lua_format" - - # TODO Added 2025-04-01 - # php-cs-fixer is marked as broken - "php_cs_fixer" - - # TODO: Added 2025-04-19 broken dependency - "phan" - "php" - "phpcbf" - "phpcs" - "phpstan" - "psalm" - ]; + brokenTools = [ ]; # TODO: respect unpackaged from generated unpackaged = [ diff --git a/tests/test-sources/plugins/by-name/rzls/default.nix b/tests/test-sources/plugins/by-name/rzls/default.nix index 2a93b747..b001267e 100644 --- a/tests/test-sources/plugins/by-name/rzls/default.nix +++ b/tests/test-sources/plugins/by-name/rzls/default.nix @@ -1,18 +1,10 @@ { empty = { - # TODO: 2025-10-03 - # Transient dependency `vmr` has a build failure - # https://github.com/NixOS/nixpkgs/issues/431811 - dependencies.roslyn_ls.enable = false; plugins.roslyn.enable = true; plugins.rzls.enable = true; }; defaults = { - # TODO: 2025-10-03 - # Transient dependency `vmr` has a build failure - # https://github.com/NixOS/nixpkgs/issues/431811 - dependencies.roslyn_ls.enable = false; plugins.roslyn.enable = true; plugins.rzls = { enable = true; diff --git a/tests/test-sources/plugins/by-name/vimtex/default.nix b/tests/test-sources/plugins/by-name/vimtex/default.nix index 39b55a04..7f259e31 100644 --- a/tests/test-sources/plugins/by-name/vimtex/default.nix +++ b/tests/test-sources/plugins/by-name/vimtex/default.nix @@ -1,19 +1,12 @@ -{ pkgs, ... }: -let - # TODO: Added 2025-06-24 texlive dependency broken - disableTexlivePackageOnDarwin = pkgs.lib.optionalAttrs pkgs.stdenv.isDarwin { - texlivePackage = null; - }; -in { empty = { - plugins.vimtex = disableTexlivePackageOnDarwin // { + plugins.vimtex = { enable = true; }; }; example = { - plugins.vimtex = disableTexlivePackageOnDarwin // { + plugins.vimtex = { enable = true; settings = { @@ -70,7 +63,7 @@ in }; no-packages = { - plugins.vimtex = disableTexlivePackageOnDarwin // { + plugins.vimtex = { enable = true; xdotoolPackage = null; zathuraPackage = null;