From 02c64abf1e892220cb62ce3b7e1598030fb6a61c Mon Sep 17 00:00:00 2001
From: pennae <github@quasiparticle.net>
Date: Tue, 26 Dec 2023 05:44:52 +0100
Subject: [PATCH] use translation table for drv string parsing
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

the table is very small compared to cache sizes and a single indexed
load is faster than three comparisons.

before:

Benchmark 1: nix eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
  Time (mean ± σ):      6.907 s ±  0.012 s    [User: 5.272 s, System: 1.429 s]
  Range (min … max):    6.893 s …  6.926 s    10 runs

after:

Benchmark 1: nix eval --raw --impure --expr 'with import <nixpkgs/nixos> {}; system'
  Time (mean ± σ):      6.883 s ±  0.016 s    [User: 5.250 s, System: 1.424 s]
  Range (min … max):    6.860 s …  6.905 s    10 runs
---
 src/libstore/derivations.cc | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/src/libstore/derivations.cc b/src/libstore/derivations.cc
index 89d902917..89a345057 100644
--- a/src/libstore/derivations.cc
+++ b/src/libstore/derivations.cc
@@ -174,6 +174,17 @@ struct StringViewStream {
         return c;
     }
 };
+
+constexpr struct Escapes {
+    char map[256];
+    constexpr Escapes() {
+        for (int i = 0; i < 256; i++) map[i] = (char) (unsigned char) i;
+        map[(int) (unsigned char) 'n'] = '\n';
+        map[(int) (unsigned char) 'r'] = '\r';
+        map[(int) (unsigned char) 't'] = '\t';
+    }
+    char operator[](char c) const { return map[(unsigned char) c]; }
+} escapes;
 }
 
 
@@ -213,10 +224,7 @@ static BackedStringView parseString(StringViewStream & str)
     for (c = content.begin(), end = content.end(); c != end; c++)
         if (*c == '\\') {
             c++;
-            if (*c == 'n') res += '\n';
-            else if (*c == 'r') res += '\r';
-            else if (*c == 't') res += '\t';
-            else res += *c;
+            res += escapes[*c];
         }
         else res += *c;
     return res;