nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-20 01:09:37 +01:00
Code Activity

[TMP] Try inlining the getAttrField function

Browse source 
See what’s making things slow
This commit is contained in:
regnat 2021-06-02 16:56:21 +02:00
parent b012852cb2
commit 2021b1d8d1
1 changed files with 28 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

29
src/libexpr/eval.cc
View file

@ -1154,7 +1154,34 @@ void ExprSelect::eval(EvalState & state, Env & env, Value & v)
selector.push_back(getName(i, state, env)); selector.push_back(getName(i, state, env));
try { try {
state.getAttrField(vTmp, selector, pos, v); Pos * pos2 = 0;
Value * vAttrs = &vTmp;
try {
for (auto & name : selector) {
nrLookups++;
Bindings::iterator j;
state.forceValue(*vAttrs, pos);
if (vAttrs->type() != nAttrs ||
(j = vAttrs->attrs->find(name)) == vAttrs->attrs->end()) {
throw MissingField("attribute '%s' missing", name);
}
vAttrs = j->value;
pos2 = j->pos;
if (state.countCalls && pos2) state.attrSelects[*pos2]++;
}
state.forceValue(*vAttrs, ( pos2 != NULL ? *pos2 : pos ) );
} catch (Error & e) {
if (pos2 && pos2->file != state.sDerivationNix) {
vector<string> strSelector;
addErrorTrace(e, *pos2, "while evaluating the attribute '%1%'", concatStringsSep(".", selector));
}
throw;
}
v = *vAttrs;
} catch (MissingField & field) { } catch (MissingField & field) {
if (def) { if (def) {
def->eval(state, env, v); def->eval(state, env, v);