From 283a9c4c5aefc4d55b6643a483b64bfea8ae597b Mon Sep 17 00:00:00 2001 From: Farid Zakaria Date: Sun, 28 Sep 2025 20:29:35 -0700 Subject: [PATCH] shellcheck fix: tests/functional/local-overlay-store/optimise-inner.sh --- maintainers/flake-module.nix | 1 - tests/functional/local-overlay-store/optimise-inner.sh | 4 ++-- tests/functional/local-overlay-store/optimise.sh | 1 + 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix index e5b38a931..388a9755c 100644 --- a/maintainers/flake-module.nix +++ b/maintainers/flake-module.nix @@ -136,7 +136,6 @@ ''^tests/functional/local-overlay-store/delete-refs\.sh$'' ''^tests/functional/local-overlay-store/gc-inner\.sh$'' ''^tests/functional/local-overlay-store/gc\.sh$'' - ''^tests/functional/local-overlay-store/optimise-inner\.sh$'' ''^tests/functional/logging\.sh$'' ''^tests/functional/misc\.sh$'' ''^tests/functional/multiple-outputs\.sh$'' diff --git a/tests/functional/local-overlay-store/optimise-inner.sh b/tests/functional/local-overlay-store/optimise-inner.sh index eafbc77f7..40cd1c531 100755 --- a/tests/functional/local-overlay-store/optimise-inner.sh +++ b/tests/functional/local-overlay-store/optimise-inner.sh @@ -38,8 +38,8 @@ overlayPath="$storeBRoot/nix/store/$dupFilename" lowerInode=$(stat -c %i "$lowerPath") upperInode=$(stat -c %i "$upperPath") overlayInode=$(stat -c %i "$overlayPath") -[[ $upperInode == $overlayInode ]] -[[ $upperInode != $lowerInode ]] +[[ $upperInode == "$overlayInode" ]] +[[ $upperInode != "$lowerInode" ]] # Run optimise to deduplicate store paths nix-store --store "$storeB" --optimise diff --git a/tests/functional/local-overlay-store/optimise.sh b/tests/functional/local-overlay-store/optimise.sh index a524a675e..a11c450d7 100755 --- a/tests/functional/local-overlay-store/optimise.sh +++ b/tests/functional/local-overlay-store/optimise.sh @@ -1,3 +1,4 @@ +# shellcheck shell=bash source common.sh source ../common/init.sh