1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-08 19:46:02 +01:00

shellcheck fix: tests/functional/nix-channel.sh

This commit is contained in:
Farid Zakaria 2025-09-29 09:51:46 -07:00
parent 2bfc9019fa
commit 2b1a0963f9
2 changed files with 26 additions and 27 deletions

View file

@ -106,7 +106,6 @@
enable = true; enable = true;
excludes = [ excludes = [
# We haven't linted these files yet # We haven't linted these files yet
''^tests/functional/nix-channel\.sh$''
''^tests/functional/nix-collect-garbage-d\.sh$'' ''^tests/functional/nix-collect-garbage-d\.sh$''
''^tests/functional/nix-copy-ssh-common\.sh$'' ''^tests/functional/nix-copy-ssh-common\.sh$''
''^tests/functional/nix-copy-ssh-ng\.sh$'' ''^tests/functional/nix-copy-ssh-ng\.sh$''

View file

@ -4,7 +4,7 @@ source common.sh
clearProfiles clearProfiles
rm -f $TEST_HOME/.nix-channels $TEST_HOME/.nix-profile rm -f "$TEST_HOME"/.nix-channels "$TEST_HOME"/.nix-profile
# Test add/list/remove. # Test add/list/remove.
nix-channel --add http://foo/bar xyzzy nix-channel --add http://foo/bar xyzzy
@ -12,8 +12,8 @@ nix-channel --list | grepQuiet http://foo/bar
nix-channel --remove xyzzy nix-channel --remove xyzzy
[[ $(nix-channel --list-generations | wc -l) == 1 ]] [[ $(nix-channel --list-generations | wc -l) == 1 ]]
[ -e $TEST_HOME/.nix-channels ] [ -e "$TEST_HOME"/.nix-channels ]
[ "$(cat $TEST_HOME/.nix-channels)" = '' ] [ "$(cat "$TEST_HOME"/.nix-channels)" = '' ]
# Test the XDG Base Directories support # Test the XDG Base Directories support
@ -25,47 +25,47 @@ nix-channel --remove xyzzy
unset NIX_CONFIG unset NIX_CONFIG
[ -e $TEST_HOME/.local/state/nix/channels ] [ -e "$TEST_HOME"/.local/state/nix/channels ]
[ "$(cat $TEST_HOME/.local/state/nix/channels)" = '' ] [ "$(cat "$TEST_HOME"/.local/state/nix/channels)" = '' ]
# Create a channel. # Create a channel.
rm -rf $TEST_ROOT/foo rm -rf "$TEST_ROOT"/foo
mkdir -p $TEST_ROOT/foo mkdir -p "$TEST_ROOT"/foo
drvPath=$(nix-instantiate dependencies.nix) drvPath=$(nix-instantiate dependencies.nix)
nix copy --to file://$TEST_ROOT/foo?compression="bzip2" $(nix-store -r "$drvPath") nix copy --to file://"$TEST_ROOT"/foo?compression="bzip2" "$(nix-store -r "$drvPath")"
rm -rf $TEST_ROOT/nixexprs rm -rf "$TEST_ROOT"/nixexprs
mkdir -p $TEST_ROOT/nixexprs mkdir -p "$TEST_ROOT"/nixexprs
cp "${config_nix}" dependencies.nix dependencies.builder*.sh $TEST_ROOT/nixexprs/ cp "${config_nix}" dependencies.nix dependencies.builder*.sh "$TEST_ROOT"/nixexprs/
ln -s dependencies.nix $TEST_ROOT/nixexprs/default.nix ln -s dependencies.nix "$TEST_ROOT"/nixexprs/default.nix
(cd $TEST_ROOT && tar cvf - nixexprs) | bzip2 > $TEST_ROOT/foo/nixexprs.tar.bz2 (cd "$TEST_ROOT" && tar cvf - nixexprs) | bzip2 > "$TEST_ROOT"/foo/nixexprs.tar.bz2
# Test the update action. # Test the update action.
nix-channel --add file://$TEST_ROOT/foo nix-channel --add file://"$TEST_ROOT"/foo
nix-channel --update nix-channel --update
[[ $(nix-channel --list-generations | wc -l) == 2 ]] [[ $(nix-channel --list-generations | wc -l) == 2 ]]
# Do a query. # Do a query.
nix-env -qa \* --meta --xml --out-path > $TEST_ROOT/meta.xml nix-env -qa \* --meta --xml --out-path > "$TEST_ROOT"/meta.xml
grepQuiet 'meta.*description.*Random test package' $TEST_ROOT/meta.xml grepQuiet 'meta.*description.*Random test package' "$TEST_ROOT"/meta.xml
grepQuiet 'item.*attrPath="foo".*name="dependencies-top"' $TEST_ROOT/meta.xml grepQuiet 'item.*attrPath="foo".*name="dependencies-top"' "$TEST_ROOT"/meta.xml
# Do an install. # Do an install.
nix-env -i dependencies-top nix-env -i dependencies-top
[ -e $TEST_HOME/.nix-profile/foobar ] [ -e "$TEST_HOME"/.nix-profile/foobar ]
# Test updating from a tarball # Test updating from a tarball
nix-channel --add file://$TEST_ROOT/foo/nixexprs.tar.bz2 bar nix-channel --add file://"$TEST_ROOT"/foo/nixexprs.tar.bz2 bar
nix-channel --update nix-channel --update
# Do a query. # Do a query.
nix-env -qa \* --meta --xml --out-path > $TEST_ROOT/meta.xml nix-env -qa \* --meta --xml --out-path > "$TEST_ROOT"/meta.xml
grepQuiet 'meta.*description.*Random test package' $TEST_ROOT/meta.xml grepQuiet 'meta.*description.*Random test package' "$TEST_ROOT"/meta.xml
grepQuiet 'item.*attrPath="bar".*name="dependencies-top"' $TEST_ROOT/meta.xml grepQuiet 'item.*attrPath="bar".*name="dependencies-top"' "$TEST_ROOT"/meta.xml
grepQuiet 'item.*attrPath="foo".*name="dependencies-top"' $TEST_ROOT/meta.xml grepQuiet 'item.*attrPath="foo".*name="dependencies-top"' "$TEST_ROOT"/meta.xml
# Do an install. # Do an install.
nix-env -i dependencies-top nix-env -i dependencies-top
[ -e $TEST_HOME/.nix-profile/foobar ] [ -e "$TEST_HOME"/.nix-profile/foobar ]
# Test evaluation through a channel symlink (#9882). # Test evaluation through a channel symlink (#9882).
drvPath=$(nix-instantiate '<foo/dependencies.nix>') drvPath=$(nix-instantiate '<foo/dependencies.nix>')
@ -73,9 +73,9 @@ drvPath=$(nix-instantiate '<foo/dependencies.nix>')
# Add a test for the special case behaviour of 'nixpkgs' in the # Add a test for the special case behaviour of 'nixpkgs' in the
# channels for root (see EvalSettings::getDefaultNixPath()). # channels for root (see EvalSettings::getDefaultNixPath()).
if ! isTestOnNixOS; then if ! isTestOnNixOS; then
nix-channel --add file://$TEST_ROOT/foo nixpkgs nix-channel --add file://"$TEST_ROOT"/foo nixpkgs
nix-channel --update nix-channel --update
mv $TEST_HOME/.local/state/nix/profiles $TEST_ROOT/var/nix/profiles/per-user/root mv "$TEST_HOME"/.local/state/nix/profiles "$TEST_ROOT"/var/nix/profiles/per-user/root
drvPath2=$(nix-instantiate '<nixpkgs>') drvPath2=$(nix-instantiate '<nixpkgs>')
[[ "$drvPath" = "$drvPath2" ]] [[ "$drvPath" = "$drvPath2" ]]
fi fi