From 2bfc9019fad4cd1521bb42aa2244eb9cf6d15578 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 09:46:43 -0700
Subject: [PATCH] shellcheck fix: tests/functional/nix-build.sh

---
 maintainers/flake-module.nix  |  1 -
 tests/functional/nix-build.sh | 28 +++++++++++++++-------------
 2 files changed, 15 insertions(+), 14 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index cf13e1e80..a21fb214c 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/nix-build\.sh$''
               ''^tests/functional/nix-channel\.sh$''
               ''^tests/functional/nix-collect-garbage-d\.sh$''
               ''^tests/functional/nix-copy-ssh-common\.sh$''
diff --git a/tests/functional/nix-build.sh b/tests/functional/nix-build.sh
index 091e429e0..33973c628 100755
--- a/tests/functional/nix-build.sh
+++ b/tests/functional/nix-build.sh
@@ -6,30 +6,30 @@ TODO_NixOS
 
 clearStoreIfPossible
 
-outPath=$(nix-build dependencies.nix -o $TEST_ROOT/result)
-test "$(cat $TEST_ROOT/result/foobar)" = FOOBAR
+outPath=$(nix-build dependencies.nix -o "$TEST_ROOT"/result)
+test "$(cat "$TEST_ROOT"/result/foobar)" = FOOBAR
 
 # The result should be retained by a GC.
 echo A
-target=$(readLink $TEST_ROOT/result)
+target=$(readLink "$TEST_ROOT"/result)
 echo B
-echo target is $target
+echo target is "$target"
 nix-store --gc
-test -e $target/foobar
+test -e "$target"/foobar
 
 # But now it should be gone.
-rm $TEST_ROOT/result
+rm "$TEST_ROOT"/result
 nix-store --gc
-if test -e $target/foobar; then false; fi
+if test -e "$target"/foobar; then false; fi
 
-outPath2=$(nix-build $(nix-instantiate dependencies.nix) --no-out-link)
-[[ $outPath = $outPath2 ]]
+outPath2=$(nix-build "$(nix-instantiate dependencies.nix)" --no-out-link)
+[[ $outPath = "$outPath2" ]]
 
-outPath2=$(nix-build $(nix-instantiate dependencies.nix)!out --no-out-link)
-[[ $outPath = $outPath2 ]]
+outPath2=$(nix-build "$(nix-instantiate dependencies.nix)"!out --no-out-link)
+[[ $outPath = "$outPath2" ]]
 
-outPath2=$(nix-store -r $(nix-instantiate --add-root $TEST_ROOT/indirect dependencies.nix)!out)
-[[ $outPath = $outPath2 ]]
+outPath2=$(nix-store -r "$(nix-instantiate --add-root "$TEST_ROOT"/indirect dependencies.nix)"!out)
+[[ $outPath = "$outPath2" ]]
 
 # The order of the paths on stdout must correspond to the -A options
 # https://github.com/NixOS/nix/issues/4197
@@ -39,9 +39,11 @@ input1="$(nix-build nix-build-examples.nix -A input1 --no-out-link)"
 input2="$(nix-build nix-build-examples.nix -A input2 --no-out-link)"
 body="$(nix-build nix-build-examples.nix -A body --no-out-link)"
 
+# shellcheck disable=SC2046,SC2005
 outPathsA="$(echo $(nix-build nix-build-examples.nix -A input0 -A input1 -A input2 -A body --no-out-link))"
 [[ "$outPathsA" = "$input0 $input1 $input2 $body" ]]
 
 # test a different ordering to make sure it fails, not just in 23 out of 24 permutations
+# shellcheck disable=SC2046,SC2005
 outPathsB="$(echo $(nix-build nix-build-examples.nix -A body -A input1 -A input2 -A input0 --no-out-link))"
 [[ "$outPathsB" = "$body $input1 $input2 $input0" ]]