From 326d626ad7f1708ed107bf0dd704e89bbed31720 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Sun, 28 Sep 2025 20:32:12 -0700
Subject: [PATCH] shellcheck fix:
 tests/functional/local-overlay-store/delete-refs-inner.sh

---
 maintainers/flake-module.nix                    |  2 --
 .../local-overlay-store/delete-refs-inner.sh    | 17 +++++++++--------
 .../local-overlay-store/delete-refs.sh          |  1 +
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 522e7cdb8..f527a6d39 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -132,8 +132,6 @@
               ''^tests/functional/local-overlay-store/common\.sh$''
               ''^tests/functional/local-overlay-store/delete-duplicate-inner\.sh$''
               ''^tests/functional/local-overlay-store/delete-duplicate\.sh$''
-              ''^tests/functional/local-overlay-store/delete-refs-inner\.sh$''
-              ''^tests/functional/local-overlay-store/delete-refs\.sh$''
               ''^tests/functional/logging\.sh$''
               ''^tests/functional/misc\.sh$''
               ''^tests/functional/multiple-outputs\.sh$''
diff --git a/tests/functional/local-overlay-store/delete-refs-inner.sh b/tests/functional/local-overlay-store/delete-refs-inner.sh
index 385eeadc9..f54ef2bb6 100644
--- a/tests/functional/local-overlay-store/delete-refs-inner.sh
+++ b/tests/functional/local-overlay-store/delete-refs-inner.sh
@@ -15,6 +15,7 @@ initLowerStore
 mountOverlayfs
 
 export NIX_REMOTE="$storeB"
+# shellcheck disable=SC2034
 stateB="$storeBRoot/nix/var/nix"
 hermetic=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg withFinalRefs true --arg seed 2)
 input1=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg withFinalRefs true --arg seed 2 -A passthru.input1 -j0)
@@ -22,18 +23,18 @@ input2=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg
 input3=$(nix-build ../hermetic.nix --no-out-link --arg busybox "$busybox" --arg withFinalRefs true --arg seed 2 -A passthru.input3 -j0)
 
 # Can't delete because referenced
-expectStderr 1 nix-store --delete $input1 | grepQuiet "Cannot delete path"
-expectStderr 1 nix-store --delete $input2 | grepQuiet "Cannot delete path"
-expectStderr 1 nix-store --delete $input3 | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --delete "$input1" | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --delete "$input2" | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --delete "$input3" | grepQuiet "Cannot delete path"
 
 # These same paths are referenced in the lower layer (by the seed 1
 # build done in `initLowerStore`).
-expectStderr 1 nix-store --store "$storeA" --delete $input2 | grepQuiet "Cannot delete path"
-expectStderr 1 nix-store --store "$storeA" --delete $input3 | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --store "$storeA" --delete "$input2" | grepQuiet "Cannot delete path"
+expectStderr 1 nix-store --store "$storeA" --delete "$input3" | grepQuiet "Cannot delete path"
 
 # Can delete
-nix-store --delete $hermetic
+nix-store --delete "$hermetic"
 
 # Now unreferenced in upper layer, can delete
-nix-store --delete $input3
-nix-store --delete $input2
+nix-store --delete "$input3"
+nix-store --delete "$input2"
diff --git a/tests/functional/local-overlay-store/delete-refs.sh b/tests/functional/local-overlay-store/delete-refs.sh
index 62295aaa1..4fe08a077 100755
--- a/tests/functional/local-overlay-store/delete-refs.sh
+++ b/tests/functional/local-overlay-store/delete-refs.sh
@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 source common.sh
 source ../common/init.sh