From 32818483a52750cac727e2f5b53ae16f46fc14d2 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 10:03:50 -0700
Subject: [PATCH] shellcheck fix: tests/functional/optimise-store.sh

---
 maintainers/flake-module.nix       |  1 -
 tests/functional/optimise-store.sh | 17 ++++++++++-------
 2 files changed, 10 insertions(+), 8 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index f783f0261..5b743e61d 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/optimise-store\.sh$''
               ''^tests/functional/output-normalization\.sh$''
               ''^tests/functional/parallel\.builder\.sh$''
               ''^tests/functional/parallel\.sh$''
diff --git a/tests/functional/optimise-store.sh b/tests/functional/optimise-store.sh
index 05c4c41e4..332a308c2 100755
--- a/tests/functional/optimise-store.sh
+++ b/tests/functional/optimise-store.sh
@@ -4,28 +4,31 @@ source common.sh
 
 clearStoreIfPossible
 
+# shellcheck disable=SC2016
 outPath1=$(echo 'with import '"${config_nix}"'; mkDerivation { name = "foo1"; builder = builtins.toFile "builder" "mkdir $out; echo hello > $out/foo"; }' | nix-build - --no-out-link --auto-optimise-store)
+# shellcheck disable=SC2016
 outPath2=$(echo 'with import '"${config_nix}"'; mkDerivation { name = "foo2"; builder = builtins.toFile "builder" "mkdir $out; echo hello > $out/foo"; }' | nix-build - --no-out-link --auto-optimise-store)
 
 TODO_NixOS # ignoring the client-specified setting 'auto-optimise-store', because it is a restricted setting and you are not a trusted user
   # TODO: only continue when trusted user or root
 
-inode1="$(stat --format=%i $outPath1/foo)"
-inode2="$(stat --format=%i $outPath2/foo)"
+inode1="$(stat --format=%i "$outPath1"/foo)"
+inode2="$(stat --format=%i "$outPath2"/foo)"
 if [ "$inode1" != "$inode2" ]; then
     echo "inodes do not match"
     exit 1
 fi
 
-nlink="$(stat --format=%h $outPath1/foo)"
+nlink="$(stat --format=%h "$outPath1"/foo)"
 if [ "$nlink" != 3 ]; then
     echo "link count incorrect"
     exit 1
 fi
 
+# shellcheck disable=SC2016
 outPath3=$(echo 'with import '"${config_nix}"'; mkDerivation { name = "foo3"; builder = builtins.toFile "builder" "mkdir $out; echo hello > $out/foo"; }' | nix-build - --no-out-link)
 
-inode3="$(stat --format=%i $outPath3/foo)"
+inode3="$(stat --format=%i "$outPath3"/foo)"
 if [ "$inode1" = "$inode3" ]; then
     echo "inodes match unexpectedly"
     exit 1
@@ -34,8 +37,8 @@ fi
 # XXX: This should work through the daemon too
 NIX_REMOTE="" nix-store --optimise
 
-inode1="$(stat --format=%i $outPath1/foo)"
-inode3="$(stat --format=%i $outPath3/foo)"
+inode1="$(stat --format=%i "$outPath1"/foo)"
+inode3="$(stat --format=%i "$outPath3"/foo)"
 if [ "$inode1" != "$inode3" ]; then
     echo "inodes do not match"
     exit 1
@@ -43,7 +46,7 @@ fi
 
 nix-store --gc
 
-if [ -n "$(ls $NIX_STORE_DIR/.links)" ]; then
+if [ -n "$(ls "$NIX_STORE_DIR"/.links)" ]; then
     echo ".links directory not empty after GC"
     exit 1
 fi