mirror of
https://github.com/NixOS/nix.git
synced 2025-11-08 19:46:02 +01:00
ci: Split formatting check into a separate job, gate other jobs
This makes the CI fail fast and more explicitly in case the formatting is incorrect and provides a better error messages. This also ensures that we don't burn CI on useless checks for code that wouldn't pass lints anyway.
This commit is contained in:
parent
73d3ab05b6
commit
35d8ffe01d
2 changed files with 46 additions and 0 deletions
22
.github/workflows/ci.yml
vendored
22
.github/workflows/ci.yml
vendored
|
|
@ -29,7 +29,28 @@ jobs:
|
||||||
github_token: ${{ secrets.GITHUB_TOKEN }}
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
- run: nix flake show --all-systems --json
|
- run: nix flake show --all-systems --json
|
||||||
|
|
||||||
|
pre-commit-checks:
|
||||||
|
name: pre-commit checks
|
||||||
|
runs-on: ubuntu-24.04
|
||||||
|
steps:
|
||||||
|
- uses: actions/checkout@v5
|
||||||
|
- uses: ./.github/actions/install-nix-action
|
||||||
|
with:
|
||||||
|
dogfood: ${{ github.event_name == 'workflow_dispatch' && inputs.dogfood || github.event_name != 'workflow_dispatch' }}
|
||||||
|
extra_nix_config: experimental-features = nix-command flakes
|
||||||
|
github_token: ${{ secrets.GITHUB_TOKEN }}
|
||||||
|
- uses: DeterminateSystems/magic-nix-cache-action@main
|
||||||
|
- run: ./ci/gha/tests/pre-commit-checks
|
||||||
|
|
||||||
|
basic-checks:
|
||||||
|
name: aggregate basic checks
|
||||||
|
runs-on: ubuntu-24.04
|
||||||
|
needs: [pre-commit-checks, eval]
|
||||||
|
steps:
|
||||||
|
- run: ":" # Dummy step
|
||||||
|
|
||||||
tests:
|
tests:
|
||||||
|
needs: basic-checks
|
||||||
strategy:
|
strategy:
|
||||||
fail-fast: false
|
fail-fast: false
|
||||||
matrix:
|
matrix:
|
||||||
|
|
@ -214,6 +235,7 @@ jobs:
|
||||||
docker push $IMAGE_ID:master
|
docker push $IMAGE_ID:master
|
||||||
|
|
||||||
vm_tests:
|
vm_tests:
|
||||||
|
needs: basic-checks
|
||||||
runs-on: ubuntu-24.04
|
runs-on: ubuntu-24.04
|
||||||
steps:
|
steps:
|
||||||
- uses: actions/checkout@v5
|
- uses: actions/checkout@v5
|
||||||
|
|
|
||||||
24
ci/gha/tests/pre-commit-checks
Executable file
24
ci/gha/tests/pre-commit-checks
Executable file
|
|
@ -0,0 +1,24 @@
|
||||||
|
#!/usr/bin/env bash
|
||||||
|
|
||||||
|
set -euo pipefail
|
||||||
|
|
||||||
|
system=$(nix eval --raw --impure --expr builtins.currentSystem)
|
||||||
|
|
||||||
|
echo "::group::Running pre-commit checks"
|
||||||
|
|
||||||
|
if nix build ".#checks.$system.pre-commit" -L; then
|
||||||
|
echo "::endgroup::"
|
||||||
|
exit 0
|
||||||
|
fi
|
||||||
|
|
||||||
|
echo "::error ::Changes do not pass pre-commit checks"
|
||||||
|
|
||||||
|
cat <<EOF
|
||||||
|
The code isn't formatted or doesn't pass lints. You can run pre-commit locally with:
|
||||||
|
|
||||||
|
nix develop -c ./maintainers/format.sh
|
||||||
|
EOF
|
||||||
|
|
||||||
|
echo "::endgroup::"
|
||||||
|
|
||||||
|
exit 1
|
||||||
Loading…
Add table
Add a link
Reference in a new issue