From 4192ca9131ce93ac51cde4110dfc4b1bf251e243 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 09:18:50 -0700
Subject: [PATCH] shellcheck fix: tests/functional/gc-auto.sh

---
 maintainers/flake-module.nix |  1 -
 tests/functional/gc-auto.sh  | 22 +++++++++++++---------
 2 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 12732bf90..51ac3a629 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/gc-auto\.sh$''
               ''^tests/functional/gc-concurrent\.builder\.sh$''
               ''^tests/functional/gc-concurrent\.sh$''
               ''^tests/functional/gc-concurrent2\.builder\.sh$''
diff --git a/tests/functional/gc-auto.sh b/tests/functional/gc-auto.sh
index efe3e4b2b..ea877f27f 100755
--- a/tests/functional/gc-auto.sh
+++ b/tests/functional/gc-auto.sh
@@ -2,22 +2,26 @@
 
 source common.sh
 
+# shellcheck disable=SC1111
 needLocalStore "“min-free” and “max-free” are daemon options"
 
 TODO_NixOS
 
 clearStore
 
+# shellcheck disable=SC2034
 garbage1=$(nix store add-path --name garbage1 ./nar-access.sh)
+# shellcheck disable=SC2034
 garbage2=$(nix store add-path --name garbage2 ./nar-access.sh)
+# shellcheck disable=SC2034
 garbage3=$(nix store add-path --name garbage3 ./nar-access.sh)
 
-ls -l $garbage3
-POSIXLY_CORRECT=1 du $garbage3
+ls -l "$garbage3"
+POSIXLY_CORRECT=1 du "$garbage3"
 
 fake_free=$TEST_ROOT/fake-free
 export _NIX_TEST_FREE_SPACE_FILE=$fake_free
-echo 1100 > $fake_free
+echo 1100 > "$fake_free"
 
 fifoLock=$TEST_ROOT/fifoLock
 mkfifo "$fifoLock"
@@ -65,11 +69,11 @@ with import ${config_nix}; mkDerivation {
 EOF
 )
 
-nix build --impure -v -o $TEST_ROOT/result-A -L --expr "$expr" \
+nix build --impure -v -o "$TEST_ROOT"/result-A -L --expr "$expr" \
     --min-free 1K --max-free 2K --min-free-check-interval 1 &
 pid1=$!
 
-nix build --impure -v -o $TEST_ROOT/result-B -L --expr "$expr2" \
+nix build --impure -v -o "$TEST_ROOT"/result-B -L --expr "$expr2" \
     --min-free 1K --max-free 2K --min-free-check-interval 1 &
 pid2=$!
 
@@ -77,9 +81,9 @@ pid2=$!
 # If the first build fails, we need to postpone the failure to still allow
 # the second one to finish
 wait "$pid1" || FIRSTBUILDSTATUS=$?
-echo "unlock" > $fifoLock
-( exit ${FIRSTBUILDSTATUS:-0} )
+echo "unlock" > "$fifoLock"
+( exit "${FIRSTBUILDSTATUS:-0}" )
 wait "$pid2"
 
-[[ foo = $(cat $TEST_ROOT/result-A/bar) ]]
-[[ foo = $(cat $TEST_ROOT/result-B/bar) ]]
+[[ foo = $(cat "$TEST_ROOT"/result-A/bar) ]]
+[[ foo = $(cat "$TEST_ROOT"/result-B/bar) ]]