mirror of
https://github.com/NixOS/nix.git
synced 2025-11-11 13:06:01 +01:00
Fix handling of experimental features mid-parse
If we conditionally "declare" the argument, as we did before, based upon
weather the feature is enabled, commands like
nix --experimental-features=foo ... --thing-gated-on-foo
won't work, because the experimental feature isn't enabled until *after*
we start parsing.
Instead, allow arguments to also be associated with experimental
features (just as we did for builtins and settings), and then the
command line parser will filter out the experimental ones.
Since the effects of arguments (handler functions) are performed right
away, we get the required behavior: earlier arguments can enable later
arguments enabled!
There is just one catch: we want to keep non-positional
flags...non-positional. So if
nix --experimental-features=foo ... --thing-gated-on-foo
works, then
nix --thing-gated-on-foo --experimental-features=foo ...
should also work.
This is not my favorite long-term solution, but for now this is
implemented by delaying the requirement of needed experimental features
until *after* all the arguments have been parsed.
This commit is contained in:
parent
aa663b7e89
commit
4607ac7aed
5 changed files with 53 additions and 16 deletions
|
|
@ -450,7 +450,6 @@ template<class C> Strings quoteStrings(const C & c)
|
|||
return res;
|
||||
}
|
||||
|
||||
|
||||
/* Remove trailing whitespace from a string. FIXME: return
|
||||
std::string_view. */
|
||||
std::string chomp(std::string_view s);
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue