From 50cc70b71e0bf6a663ececc7ee09de377cd9317d Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Thu, 6 Nov 2025 13:06:08 +0100 Subject: [PATCH] Don't crash on flakerefs containing newlines Fixes #14311. (cherry picked from commit c1317017e902f34631f2f4598710114d36e84ee4) --- src/libflake/flakeref.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libflake/flakeref.cc b/src/libflake/flakeref.cc index f4ed5d6fa..14aac6e53 100644 --- a/src/libflake/flakeref.cc +++ b/src/libflake/flakeref.cc @@ -90,7 +90,8 @@ std::pair parsePathFlakeRefWithFragment( std::smatch match; auto succeeds = std::regex_match(url, match, pathFlakeRegex); - assert(succeeds); + if (!succeeds) + throw Error("invalid flakeref '%s'", url); auto path = match[1].str(); auto query = decodeQuery(match[3]); auto fragment = percentDecode(match[5].str());