From 52b9fb38e0dfc0af226a25d21197b40fa44e6c78 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 09:23:41 -0700
Subject: [PATCH] shellcheck fix: tests/functional/gc-non-blocking.sh

---
 maintainers/flake-module.nix        |  1 -
 tests/functional/gc-non-blocking.sh | 14 ++++++++------
 2 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index dd7d1d338..b080683ff 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/gc-non-blocking\.sh$''
               ''^tests/functional/hash-convert\.sh$''
               ''^tests/functional/impure-derivations\.sh$''
               ''^tests/functional/impure-eval\.sh$''
diff --git a/tests/functional/gc-non-blocking.sh b/tests/functional/gc-non-blocking.sh
index 9cd5c0e1c..a85b8e5db 100755
--- a/tests/functional/gc-non-blocking.sh
+++ b/tests/functional/gc-non-blocking.sh
@@ -23,17 +23,17 @@ mkfifo "$fifo2"
 dummy=$(nix store add-path ./simple.nix)
 
 running=$TEST_ROOT/running
-touch $running
+touch "$running"
 
 # Start GC.
-(_NIX_TEST_GC_SYNC_1=$fifo1 _NIX_TEST_GC_SYNC_2=$fifo2 nix-store --gc -vvvvv; rm $running) &
+(_NIX_TEST_GC_SYNC_1=$fifo1 _NIX_TEST_GC_SYNC_2=$fifo2 nix-store --gc -vvvvv; rm "$running") &
 pid=$!
 
 sleep 2
 
 # Delay the start of the root server to check that the build below
 # correctly handles ENOENT when connecting to the root server.
-(sleep 1; echo > $fifo1) &
+(sleep 1; echo > "$fifo1") &
 pid2=$!
 
 # Start a build. This should not be blocked by the GC in progress.
@@ -47,6 +47,8 @@ outPath=$(nix-build --max-silent-time 60 -o "$TEST_ROOT/result" -E "
 wait $pid
 wait $pid2
 
-(! test -e $running)
-(! test -e $dummy)
-test -e $outPath
+# shellcheck disable=SC2235
+(! test -e "$running")
+# shellcheck disable=SC2235
+(! test -e "$dummy")
+test -e "$outPath"