nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-09 03:56:01 +01:00
Code Activity

shellcheck fix: tests/functional/gc-concurrent.sh

Browse source
This commit is contained in:
Farid Zakaria 2025-09-29 09:21:47 -07:00
parent 613bd67574
commit 75df03204b
2 changed files with 19 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
maintainers/flake-module.nix
View file

@ -106,7 +106,6 @@
enable = true; enable = true;
excludes = [ excludes = [
# We haven't linted these files yet # We haven't linted these files yet
''^tests/functional/gc-concurrent\.sh$''
''^tests/functional/gc-concurrent2\.builder\.sh$'' ''^tests/functional/gc-concurrent2\.builder\.sh$''
''^tests/functional/gc-non-blocking\.sh$'' ''^tests/functional/gc-non-blocking\.sh$''
''^tests/functional/hash-convert\.sh$'' ''^tests/functional/hash-convert\.sh$''

34
tests/functional/gc-concurrent.sh
View file

@ -10,54 +10,58 @@ lockFifo1=$TEST_ROOT/test1.fifo
mkfifo "$lockFifo1" mkfifo "$lockFifo1"
drvPath1=$(nix-instantiate gc-concurrent.nix -A test1 --argstr lockFifo "$lockFifo1") drvPath1=$(nix-instantiate gc-concurrent.nix -A test1 --argstr lockFifo "$lockFifo1")
outPath1=$(nix-store -q $drvPath1) outPath1=$(nix-store -q "$drvPath1")
drvPath2=$(nix-instantiate gc-concurrent.nix -A test2) drvPath2=$(nix-instantiate gc-concurrent.nix -A test2)
outPath2=$(nix-store -q $drvPath2) outPath2=$(nix-store -q "$drvPath2")
drvPath3=$(nix-instantiate simple.nix) drvPath3=$(nix-instantiate simple.nix)
outPath3=$(nix-store -r $drvPath3) outPath3=$(nix-store -r "$drvPath3")
(! test -e $outPath3.lock) # shellcheck disable=SC2235
touch $outPath3.lock (! test -e "$outPath3".lock)
touch "$outPath3".lock
rm -f "$NIX_STATE_DIR"/gcroots/foo* rm -f "$NIX_STATE_DIR"/gcroots/foo*
ln -s $drvPath2 "$NIX_STATE_DIR/gcroots/foo" ln -s "$drvPath2" "$NIX_STATE_DIR/gcroots/foo"
ln -s $outPath3 "$NIX_STATE_DIR/gcroots/foo2" ln -s "$outPath3" "$NIX_STATE_DIR/gcroots/foo2"
# Start build #1 in the background. It starts immediately. # Start build #1 in the background. It starts immediately.
nix-store -rvv "$drvPath1" & nix-store -rvv "$drvPath1" &
pid1=$! pid1=$!
# Wait for the build of $drvPath1 to start # Wait for the build of $drvPath1 to start
cat $lockFifo1 cat "$lockFifo1"
# Run the garbage collector while the build is running. # Run the garbage collector while the build is running.
nix-collect-garbage nix-collect-garbage
# Unlock the build of $drvPath1 # Unlock the build of $drvPath1
echo "" > $lockFifo1 echo "" > "$lockFifo1"
echo waiting for pid $pid1 to finish... echo waiting for pid $pid1 to finish...
wait $pid1 wait $pid1
# Check that the root of build #1 and its dependencies haven't been # Check that the root of build #1 and its dependencies haven't been
# deleted. The should not be deleted by the GC because they were # deleted. The should not be deleted by the GC because they were
# being built during the GC. # being built during the GC.
cat $outPath1/foobar cat "$outPath1"/foobar
cat $outPath1/input-2/bar cat "$outPath1"/input-2/bar
# Check that the build build $drvPath2 succeeds. # Check that the build build $drvPath2 succeeds.
# It should succeed because the derivation is a GC root. # It should succeed because the derivation is a GC root.
nix-store -rvv "$drvPath2" nix-store -rvv "$drvPath2"
cat $outPath2/foobar cat "$outPath2"/foobar
rm -f "$NIX_STATE_DIR"/gcroots/foo* rm -f "$NIX_STATE_DIR"/gcroots/foo*
# The collector should have deleted lock files for paths that have # The collector should have deleted lock files for paths that have
# been built previously. # been built previously.
(! test -e $outPath3.lock) # shellcheck disable=SC2235
(! test -e "$outPath3".lock)
# If we run the collector now, it should delete outPath1/2. # If we run the collector now, it should delete outPath1/2.
nix-collect-garbage nix-collect-garbage
(! test -e $outPath1) # shellcheck disable=SC2235
(! test -e $outPath2) (! test -e "$outPath1")
# shellcheck disable=SC2235
(! test -e "$outPath2")