From 76ed967f79993a8331638e8ed5fdb05ad513b5b3 Mon Sep 17 00:00:00 2001 From: Jon Hermansen Date: Sun, 23 Nov 2025 03:53:52 -0500 Subject: [PATCH] libstore: fix curl version check to allow 8.17.0 The single-string syntax '>=8.16.0 <8.17.0' only applied the lower bound, causing curl 8.17.0 to be incorrectly rejected. Split into two separate version_compare() calls for compatibility with Meson 1.1, since multi-argument syntax requires Meson 1.8+. --- src/libstore/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/libstore/meson.build b/src/libstore/meson.build index 2d7217513..d8927c3a6 100644 --- a/src/libstore/meson.build +++ b/src/libstore/meson.build @@ -114,7 +114,9 @@ boost = dependency( deps_other += boost curl = dependency('libcurl', 'curl', version : '>= 7.75.0') -if curl.version().version_compare('>=8.16.0 <8.17.0') +if curl.version().version_compare('>=8.16.0') and curl.version().version_compare( + '<8.17.0', +) # Out of precaution, avoid building with libcurl version that suffer from https://github.com/curl/curl/issues/19334. error( 'curl @0@ has issues with write pausing, please use libcurl < 8.16 or >= 8.17, see https://github.com/curl/curl/issues/19334'.format(