From 7ed40119906e60ff2548c3ac3bc0265b158e02c7 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Tue, 30 Sep 2025 20:00:38 -0700
Subject: [PATCH] shellcheck fix: tests/functional/referrers.sh

---
 maintainers/flake-module.nix  |  1 -
 tests/functional/referrers.sh | 18 ++++++++++--------
 2 files changed, 10 insertions(+), 9 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 5bafcd640..3f27668c8 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/referrers\.sh$''
               ''^tests/functional/remote-store\.sh$''
               ''^tests/functional/repair\.sh$''
               ''^tests/functional/restricted\.sh$''
diff --git a/tests/functional/referrers.sh b/tests/functional/referrers.sh
index 411cdb7c1..ae6b39ae1 100755
--- a/tests/functional/referrers.sh
+++ b/tests/functional/referrers.sh
@@ -11,32 +11,34 @@ clearStore
 max=500
 
 reference=$NIX_STORE_DIR/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-bla
-touch $reference
-(echo $reference && echo && echo 0) | nix-store --register-validity
+touch "$reference"
+(echo "$reference" && echo && echo 0) | nix-store --register-validity
 
 echo "making registration..."
 
 set +x
+# shellcheck disable=SC2004
 for ((n = 0; n < $max; n++)); do
     storePath=$NIX_STORE_DIR/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-$n
-    echo -n > $storePath
+    echo -n > "$storePath"
     ref2=$NIX_STORE_DIR/aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa-$((n+1))
     if test $((n+1)) = $max; then
         ref2=$reference
     fi
-    echo $storePath; echo; echo 2; echo $reference; echo $ref2
-done > $TEST_ROOT/reg_info
+    echo "$storePath"; echo; echo 2; echo "$reference"; echo "$ref2"
+done > "$TEST_ROOT"/reg_info
 set -x
 
 echo "registering..."
 
-nix-store --register-validity < $TEST_ROOT/reg_info
+nix-store --register-validity < "$TEST_ROOT"/reg_info
 
 echo "collecting garbage..."
-ln -sfn $reference "$NIX_STATE_DIR/gcroots/ref"
+ln -sfn "$reference" "$NIX_STATE_DIR/gcroots/ref"
 nix-store --gc
 
-if [ -n "$(type -p sqlite3)" -a "$(sqlite3 $NIX_STATE_DIR/db/db.sqlite 'select count(*) from Refs')" -ne 0 ]; then
+# shellcheck disable=SC2166
+if [ -n "$(type -p sqlite3)" -a "$(sqlite3 "$NIX_STATE_DIR"/db/db.sqlite 'select count(*) from Refs')" -ne 0 ]; then
     echo "referrers not cleaned up"
     exit 1
 fi