From 88275e572384803e0b39f9cb4321712d6f1baf63 Mon Sep 17 00:00:00 2001 From: John Ericson Date: Thu, 14 Aug 2025 00:16:26 -0400 Subject: [PATCH] `DerivationGoal` slight cleanup of some impure drv logic --- src/libstore/build/derivation-goal.cc | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/libstore/build/derivation-goal.cc b/src/libstore/build/derivation-goal.cc index 62b88f42f..d21590c8a 100644 --- a/src/libstore/build/derivation-goal.cc +++ b/src/libstore/build/derivation-goal.cc @@ -119,16 +119,12 @@ Goal::Co DerivationGoal::haveDerivation() worker.store.addTempRoot(*i.second.second); { - bool impure = drv->type().isImpure(); - - if (impure) - experimentalFeatureSettings.require(Xp::ImpureDerivations); - if (auto * mOutputHash = get(staticOutputHashes(worker.evalStore, *drv), wantedOutput)) { outputHash = *mOutputHash; } - if (impure) { + if (drv->type().isImpure()) { + experimentalFeatureSettings.require(Xp::ImpureDerivations); /* We don't yet have any safe way to cache an impure derivation at this step. */ co_return gaveUpOnSubstitution();