nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-21 09:49:36 +01:00
Code Activity

Store::registerDrvOutput make pure virtual

Browse source 
It should be the responsibility of implementations that don't implement
it to say so.

See also PR #9799, and issue #5729
This commit is contained in:
John Ericson 2025-09-27 16:03:43 -04:00
parent d76dc2406f
commit 88bd0c25f2
3 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/libstore/dummy-store.cc
View file

@ -258,6 +258,11 @@ struct DummyStore : virtual Store
return path; return path;
} }
void registerDrvOutput(const Realisation & output) override
{
unsupported("registerDrvOutput");
}
void narFromPath(const StorePath & path, Sink & sink) override void narFromPath(const StorePath & path, Sink & sink) override
{ {
bool visited = contents.cvisit(path, [&](const auto & kv) { bool visited = contents.cvisit(path, [&](const auto & kv) {

7
src/libstore/include/nix/store/legacy-ssh-store.hh
View file

@ -109,7 +109,7 @@ struct LegacySSHStore : public virtual Store
unsupported("addToStore"); unsupported("addToStore");
} }
virtual StorePath addToStoreFromDump( StorePath addToStoreFromDump(
Source & dump, Source & dump,
std::string_view name, std::string_view name,
FileSerialisationMethod dumpMethod = FileSerialisationMethod::NixArchive, FileSerialisationMethod dumpMethod = FileSerialisationMethod::NixArchive,
@ -121,6 +121,11 @@ struct LegacySSHStore : public virtual Store
unsupported("addToStore"); unsupported("addToStore");
} }
void registerDrvOutput(const Realisation & output) override
{
unsupported("registerDrvOutput");
}
public: public:
BuildResult buildDerivation(const StorePath & drvPath, const BasicDerivation & drv, BuildMode buildMode) override; BuildResult buildDerivation(const StorePath & drvPath, const BasicDerivation & drv, BuildMode buildMode) override;

5
src/libstore/include/nix/store/store-api.hh
View file

@ -598,10 +598,7 @@ public:
* floating-ca derivations and their dependencies as there's no way to * floating-ca derivations and their dependencies as there's no way to
* retrieve this information otherwise. * retrieve this information otherwise.
*/ */
virtual void registerDrvOutput(const Realisation & output) virtual void registerDrvOutput(const Realisation & output) = 0;
{
unsupported("registerDrvOutput");
}
virtual void registerDrvOutput(const Realisation & output, CheckSigsFlag checkSigs) virtual void registerDrvOutput(const Realisation & output, CheckSigsFlag checkSigs)
{ {