From 8b97d14c08d9d851ff4ba03bfc5851152a01e6c3 Mon Sep 17 00:00:00 2001
From: Robert Hensing <robert@roberthensing.nl>
Date: Mon, 22 Sep 2025 19:57:06 +0200
Subject: [PATCH] pre-commit: Give reason for ca test wrappers exclusion

---
 maintainers/flake-module.nix | 26 +++++++++++++++-----------
 1 file changed, 15 insertions(+), 11 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index ac8fb6f76..0c2ffe781 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -108,20 +108,9 @@
               # We haven't linted these files yet
               ''^scripts/install-multi-user\.sh$''
               ''^scripts/install-systemd-multi-user\.sh$''
-              ''^tests/functional/ca/build-dry\.sh$''
               ''^tests/functional/ca/build-with-garbage-path\.sh$''
               ''^tests/functional/ca/common\.sh$''
               ''^tests/functional/ca/concurrent-builds\.sh$''
-              ''^tests/functional/ca/eval-store\.sh$''
-              ''^tests/functional/ca/gc\.sh$''
-              ''^tests/functional/ca/import-from-derivation\.sh$''
-              ''^tests/functional/ca/new-build-cmd\.sh$''
-              ''^tests/functional/ca/nix-shell\.sh$''
-              ''^tests/functional/ca/post-hook\.sh$''
-              ''^tests/functional/ca/recursive\.sh$''
-              ''^tests/functional/ca/repl\.sh$''
-              ''^tests/functional/ca/selfref-gc\.sh$''
-              ''^tests/functional/ca/why-depends\.sh$''
               ''^tests/functional/characterisation-test-infra\.sh$''
               ''^tests/functional/common/vars-and-functions\.sh$''
               ''^tests/functional/completions\.sh$''
@@ -245,6 +234,21 @@
               # Shellcheck doesn't support fish or zsh shell syntax
               ''^misc/fish/completion\.fish$''
               ''^misc/zsh/completion\.zsh$''
+
+              # Content-addressed test files that use recursive-*looking* sourcing
+              # (cd .. && source <self>), causing shellcheck to loop
+              # They're small wrapper scripts with not a lot going on
+              ''^tests/functional/ca/build-dry\.sh$''
+              ''^tests/functional/ca/eval-store\.sh$''
+              ''^tests/functional/ca/gc\.sh$''
+              ''^tests/functional/ca/import-from-derivation\.sh$''
+              ''^tests/functional/ca/new-build-cmd\.sh$''
+              ''^tests/functional/ca/nix-shell\.sh$''
+              ''^tests/functional/ca/post-hook\.sh$''
+              ''^tests/functional/ca/recursive\.sh$''
+              ''^tests/functional/ca/repl\.sh$''
+              ''^tests/functional/ca/selfref-gc\.sh$''
+              ''^tests/functional/ca/why-depends\.sh$''
             ];
           };
         };