From a8c4cfae26da270a8554807993b29009cc9f805f Mon Sep 17 00:00:00 2001 From: John Ericson Date: Fri, 29 Aug 2025 17:49:11 -0400 Subject: [PATCH] `DerivationBuildingGoal::done*` restore `outputLocks.unlock()` This was accidentally removed in 169033001d8f9ca44d7324446cfc93932c380295. --- src/libstore/build/derivation-building-goal.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/libstore/build/derivation-building-goal.cc b/src/libstore/build/derivation-building-goal.cc index e8df06564..a15f6f35f 100644 --- a/src/libstore/build/derivation-building-goal.cc +++ b/src/libstore/build/derivation-building-goal.cc @@ -1304,6 +1304,7 @@ SingleDrvOutputs DerivationBuildingGoal::assertPathValidity() Goal::Done DerivationBuildingGoal::doneSuccess(BuildResult::Status status, SingleDrvOutputs builtOutputs) { + outputLocks.unlock(); buildResult.status = status; assert(buildResult.success()); @@ -1321,6 +1322,7 @@ Goal::Done DerivationBuildingGoal::doneSuccess(BuildResult::Status status, Singl Goal::Done DerivationBuildingGoal::doneFailure(BuildError ex) { + outputLocks.unlock(); buildResult.status = ex.status; buildResult.errorMsg = fmt("%s", Uncolored(ex.info().msg)); if (buildResult.status == BuildResult::TimedOut)