From b8c24cdaef3a7439b381eae2cc050ffff9dcb68a Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Thu, 25 Sep 2025 10:33:40 -0700
Subject: [PATCH] shellcheck fix: tests/functional/eval-store.sh

---
 maintainers/flake-module.nix   |  1 -
 tests/functional/eval-store.sh | 21 +++++++++++----------
 2 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 505424633..85a4d90f1 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -107,7 +107,6 @@
             excludes = [
               # We haven't linted these files yet
               ''^tests/functional/dump-db\.sh$''
-              ''^tests/functional/eval-store\.sh$''
               ''^tests/functional/export-graph\.sh$''
               ''^tests/functional/export\.sh$''
               ''^tests/functional/extra-sandbox-profile\.sh$''
diff --git a/tests/functional/eval-store.sh b/tests/functional/eval-store.sh
index 92faa4005..9f4b3b036 100755
--- a/tests/functional/eval-store.sh
+++ b/tests/functional/eval-store.sh
@@ -6,6 +6,7 @@ TODO_NixOS
 
 # Using `--eval-store` with the daemon will eventually copy everything
 # to the build store, invalidating most of the tests here
+# shellcheck disable=SC1111
 needLocalStore "“--eval-store” doesn't achieve much with the daemon"
 
 eval_store=$TEST_ROOT/eval-store
@@ -15,7 +16,7 @@ rm -rf "$eval_store"
 
 nix build -f dependencies.nix --eval-store "$eval_store" -o "$TEST_ROOT/result"
 [[ -e $TEST_ROOT/result/foobar ]]
-if [[ ! -n "${NIX_TESTS_CA_BY_DEFAULT:-}" ]]; then
+if [[ -z "${NIX_TESTS_CA_BY_DEFAULT:-}" ]]; then
     # Resolved CA derivations are written to store for building
     #
     # TODO when we something more systematic
@@ -23,35 +24,35 @@ if [[ ! -n "${NIX_TESTS_CA_BY_DEFAULT:-}" ]]; then
     # between scratch storage for building and the final destination
     # store, we'll be able to make this unconditional again -- resolved
     # derivations should only appear in the scratch store.
-    (! ls $NIX_STORE_DIR/*.drv)
+    (! ls "$NIX_STORE_DIR"/*.drv)
 fi
-ls $eval_store/nix/store/*.drv
+ls "$eval_store"/nix/store/*.drv
 
 clearStore
 rm -rf "$eval_store"
 
 nix-instantiate dependencies.nix --eval-store "$eval_store"
-(! ls $NIX_STORE_DIR/*.drv)
-ls $eval_store/nix/store/*.drv
+(! ls "$NIX_STORE_DIR"/*.drv)
+ls "$eval_store"/nix/store/*.drv
 
 clearStore
 rm -rf "$eval_store"
 
 nix-build dependencies.nix --eval-store "$eval_store" -o "$TEST_ROOT/result"
 [[ -e $TEST_ROOT/result/foobar ]]
-if [[ ! -n "${NIX_TESTS_CA_BY_DEFAULT:-}" ]]; then
+if [[ -z "${NIX_TESTS_CA_BY_DEFAULT:-}" ]]; then
     # See above
-    (! ls $NIX_STORE_DIR/*.drv)
+    (! ls "$NIX_STORE_DIR"/*.drv)
 fi
-ls $eval_store/nix/store/*.drv
+ls "$eval_store"/nix/store/*.drv
 
 clearStore
 rm -rf "$eval_store"
 
 # Confirm that import-from-derivation builds on the build store
 [[ $(nix eval --eval-store "$eval_store?require-sigs=false" --impure --raw --file ./ifd.nix) = hi ]]
-ls $NIX_STORE_DIR/*dependencies-top/foobar
-(! ls $eval_store/nix/store/*dependencies-top/foobar)
+ls "$NIX_STORE_DIR"/*dependencies-top/foobar
+(! ls "$eval_store"/nix/store/*dependencies-top/foobar)
 
 # Can't write .drv by default
 (! nix-instantiate dependencies.nix --eval-store "dummy://")