nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-15 23:12:44 +01:00
Code Activity

Eliminate the "store" global variable

Browse source 
Also, move a few free-standing functions into StoreAPI and Derivation.

Also, introduce a non-nullable smart pointer, ref<T>, which is just a
wrapper around std::shared_ptr ensuring that the pointer is never
null. (For reference-counted values, this is better than passing a
"T&", because the latter doesn't maintain the refcount. Usually, the
caller will have a shared_ptr keeping the value alive, but that's not
always the case, e.g., when passing a reference to a std::thread via
std::bind.)
This commit is contained in:
Eelco Dolstra 2016-02-04 14:28:26 +01:00
parent 4f7824c58e
commit c10c61449f
36 changed files with 511 additions and 458 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/nix-store/xmlgraph.cc
View file

@ -33,7 +33,7 @@ static string makeNode(const string & id)
}
void printXmlGraph(const PathSet & roots)
void printXmlGraph(StoreAPI & store, const PathSet & roots)
{
PathSet workList(roots);
PathSet doneSet;
@ -51,7 +51,7 @@ void printXmlGraph(const PathSet & roots)
cout << makeNode(path);
PathSet references;
store->queryReferences(path, references);
store.queryReferences(path, references);
for (PathSet::iterator i = references.begin();
i != references.end(); ++i)