Merge pull request #12692 from obsidiansystems/small-derivation-goal-cleanups

Small derivation goal cleanups

src/libstore/unix/build/local-derivation-goal.cc

@@ -150,6 +150,13 @@ struct LocalDerivationGoal : DerivationGoal, RestrictionContext
      */
     std::shared_ptr<AutoDelete> autoDelChroot;
 
+    /**
+     * The sort of derivation we are building.
+     *
+     * Just a cached value, can be recomputed from `drv`.
+     */
+    std::optional<DerivationType> derivationType;
+
     /**
      * Stuff we need to pass to initChild().
      */
@@ -478,7 +485,8 @@ Goal::Co LocalDerivationGoal::tryLocalBuild()
         co_return tryToBuild();
     }
 
-    assert(derivationType);
+    /* Cache this */
+    derivationType = drv->type();
 
     /* Are we doing a chroot build? */
     {