From c9fd721be95eb34516e78910bc7e49396c28e830 Mon Sep 17 00:00:00 2001
From: Farid Zakaria <farid.m.zakaria@gmail.com>
Date: Mon, 29 Sep 2025 09:52:31 -0700
Subject: [PATCH] shellcheck fix: tests/functional/nix-copy-ssh-common.sh

---
 maintainers/flake-module.nix            |  1 -
 tests/functional/nix-copy-ssh-common.sh | 15 ++++++++-------
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/maintainers/flake-module.nix b/maintainers/flake-module.nix
index 492c85bb0..a2c6801e9 100644
--- a/maintainers/flake-module.nix
+++ b/maintainers/flake-module.nix
@@ -106,7 +106,6 @@
             enable = true;
             excludes = [
               # We haven't linted these files yet
-              ''^tests/functional/nix-copy-ssh-common\.sh$''
               ''^tests/functional/nix-copy-ssh-ng\.sh$''
               ''^tests/functional/nix-copy-ssh\.sh$''
               ''^tests/functional/nix-daemon-untrusting\.sh$''
diff --git a/tests/functional/nix-copy-ssh-common.sh b/tests/functional/nix-copy-ssh-common.sh
index 5eea9612d..8154585af 100644
--- a/tests/functional/nix-copy-ssh-common.sh
+++ b/tests/functional/nix-copy-ssh-common.sh
@@ -1,3 +1,4 @@
+# shellcheck shell=bash
 proto=$1
 shift
 (( $# == 0 ))
@@ -7,7 +8,7 @@ TODO_NixOS
 clearStore
 clearCache
 
-mkdir -p $TEST_ROOT/stores
+mkdir -p "$TEST_ROOT"/stores
 
 # Create path to copy back and forth
 outPath=$(nix-build --no-out-link dependencies.nix)
@@ -37,17 +38,17 @@ if [[ "$proto" == "ssh-ng" ]]; then
     args+=(--no-check-sigs)
 fi
 
-[ ! -f ${remoteRoot}${outPath}/foobar ]
-nix copy "${args[@]}" --to "$remoteStore" $outPath
-[ -f ${remoteRoot}${outPath}/foobar ]
+[ ! -f "${remoteRoot}""${outPath}"/foobar ]
+nix copy "${args[@]}" --to "$remoteStore" "$outPath"
+[ -f "${remoteRoot}""${outPath}"/foobar ]
 
 # Copy back from store
 
 clearStore
 
-[ ! -f $outPath/foobar ]
-nix copy --no-check-sigs --from "$remoteStore" $outPath
-[ -f $outPath/foobar ]
+[ ! -f "$outPath"/foobar ]
+nix copy --no-check-sigs --from "$remoteStore" "$outPath"
+[ -f "$outPath"/foobar ]
 
 # Check --substitute-on-destination, avoid corrupted store