nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-09 03:56:01 +01:00
Code Activity

shellcheck fix: tests/functional/repair.sh

Browse source
This commit is contained in:
Farid Zakaria 2025-09-30 20:04:26 -07:00
parent 06f21e101f
commit d35d86da89
2 changed files with 46 additions and 40 deletions
Download patch file Download diff file Expand all files Collapse all files

2
maintainers/flake-module.nix
View file

@ -106,8 +106,6 @@
enable = true; enable = true;
excludes = [ excludes = [
# We haven't linted these files yet # We haven't linted these files yet
''^tests/functional/remote-store\.sh$''
''^tests/functional/repair\.sh$''
''^tests/functional/restricted\.sh$'' ''^tests/functional/restricted\.sh$''
''^tests/functional/search\.sh$'' ''^tests/functional/search\.sh$''
''^tests/functional/secure-drv-outputs\.sh$'' ''^tests/functional/secure-drv-outputs\.sh$''

84
tests/functional/repair.sh
View file

@ -8,39 +8,43 @@ TODO_NixOS
clearStore clearStore
path=$(nix-build dependencies.nix -o $TEST_ROOT/result) path=$(nix-build dependencies.nix -o "$TEST_ROOT"/result)
path2=$(nix-store -qR $path | grep input-2) path2=$(nix-store -qR "$path" | grep input-2)
nix-store --verify --check-contents -v nix-store --verify --check-contents -v
hash=$(nix-hash $path2) hash=$(nix-hash "$path2")
# Corrupt a path and check whether nix-build --repair can fix it. # Corrupt a path and check whether nix-build --repair can fix it.
chmod u+w $path2 chmod u+w "$path2"
touch $path2/bad touch "$path2"/bad
(! nix-store --verify --check-contents -v) (! nix-store --verify --check-contents -v)
# The path can be repaired by rebuilding the derivation. # The path can be repaired by rebuilding the derivation.
nix-store --verify --check-contents --repair nix-store --verify --check-contents --repair
(! [ -e $path2/bad ]) # shellcheck disable=SC2235
(! [ -w $path2 ]) (! [ -e "$path2"/bad ])
# shellcheck disable=SC2235
(! [ -w "$path2" ])
nix-store --verify-path $path2 nix-store --verify-path "$path2"
# Re-corrupt and delete the deriver. Now --verify --repair should # Re-corrupt and delete the deriver. Now --verify --repair should
# not work. # not work.
chmod u+w $path2 chmod u+w "$path2"
touch $path2/bad touch "$path2"/bad
nix-store --delete $(nix-store -q --referrers-closure $(nix-store -qd $path2)) # shellcheck disable=SC2046
nix-store --delete $(nix-store -q --referrers-closure "$(nix-store -qd "$path2")")
(! nix-store --verify --check-contents --repair) (! nix-store --verify --check-contents --repair)
nix-build dependencies.nix -o $TEST_ROOT/result --repair nix-build dependencies.nix -o "$TEST_ROOT"/result --repair
if [ "$(nix-hash $path2)" != "$hash" -o -e $path2/bad ]; then # shellcheck disable=SC2166
if [ "$(nix-hash "$path2")" != "$hash" -o -e "$path2"/bad ]; then
echo "path not repaired properly" >&2 echo "path not repaired properly" >&2
exit 1 exit 1
fi fi
@ -49,79 +53,83 @@ fi
# --verify can fix it. # --verify can fix it.
clearCache clearCache
nix copy --to file://$cacheDir $path nix copy --to file://"$cacheDir" "$path"
chmod u+w $path2 chmod u+w "$path2"
rm -rf $path2 rm -rf "$path2"
nix-store --verify --check-contents --repair --substituters "file://$cacheDir" --no-require-sigs nix-store --verify --check-contents --repair --substituters "file://$cacheDir" --no-require-sigs
if [ "$(nix-hash $path2)" != "$hash" -o -e $path2/bad ]; then # shellcheck disable=SC2166
if [ "$(nix-hash "$path2")" != "$hash" -o -e "$path2"/bad ]; then
echo "path not repaired properly" >&2 echo "path not repaired properly" >&2
exit 1 exit 1
fi fi
# Check --verify-path and --repair-path. # Check --verify-path and --repair-path.
nix-store --verify-path $path2 nix-store --verify-path "$path2"
chmod u+w $path2 chmod u+w "$path2"
rm -rf $path2 rm -rf "$path2"
if nix-store --verify-path $path2; then if nix-store --verify-path "$path2"; then
echo "nix-store --verify-path succeeded unexpectedly" >&2 echo "nix-store --verify-path succeeded unexpectedly" >&2
exit 1 exit 1
fi fi
nix-store --repair-path $path2 --substituters "file://$cacheDir" --no-require-sigs nix-store --repair-path "$path2" --substituters "file://$cacheDir" --no-require-sigs
if [ "$(nix-hash $path2)" != "$hash" -o -e $path2/bad ]; then # shellcheck disable=SC2166
if [ "$(nix-hash "$path2")" != "$hash" -o -e "$path2"/bad ]; then
echo "path not repaired properly" >&2 echo "path not repaired properly" >&2
exit 1 exit 1
fi fi
# Check that --repair-path also checks content of optimised symlinks (1/2) # Check that --repair-path also checks content of optimised symlinks (1/2)
nix-store --verify-path $path2 nix-store --verify-path "$path2"
if (! nix-store --optimize); then if (! nix-store --optimize); then
echo "nix-store --optimize failed to optimize the store" >&2 echo "nix-store --optimize failed to optimize the store" >&2
exit 1 exit 1
fi fi
chmod u+w $path2/bar chmod u+w "$path2"/bar
echo 'rabrab' > $path2/bar # different length echo 'rabrab' > "$path2"/bar # different length
if nix-store --verify-path $path2; then if nix-store --verify-path "$path2"; then
echo "nix-store --verify-path did not detect .links file corruption" >&2 echo "nix-store --verify-path did not detect .links file corruption" >&2
exit 1 exit 1
fi fi
nix-store --repair-path $path2 --option auto-optimise-store true nix-store --repair-path "$path2" --option auto-optimise-store true
if [ "$(nix-hash $path2)" != "$hash" -o "BAR" != "$(< $path2/bar)" ]; then # shellcheck disable=SC2166
if [ "$(nix-hash "$path2")" != "$hash" -o "BAR" != "$(< "$path2"/bar)" ]; then
echo "path not repaired properly" >&2 echo "path not repaired properly" >&2
exit 1 exit 1
fi fi
# Check that --repair-path also checks content of optimised symlinks (2/2) # Check that --repair-path also checks content of optimised symlinks (2/2)
nix-store --verify-path $path2 nix-store --verify-path "$path2"
if (! nix-store --optimize); then if (! nix-store --optimize); then
echo "nix-store --optimize failed to optimize the store" >&2 echo "nix-store --optimize failed to optimize the store" >&2
exit 1 exit 1
fi fi
chmod u+w $path2 chmod u+w "$path2"
chmod u+w $path2/bar chmod u+w "$path2"/bar
sed -e 's/./X/g' < $path2/bar > $path2/tmp # same length, different content. sed -e 's/./X/g' < "$path2"/bar > "$path2"/tmp # same length, different content.
cp $path2/tmp $path2/bar cp "$path2"/tmp "$path2"/bar
rm $path2/tmp rm "$path2"/tmp
if nix-store --verify-path $path2; then if nix-store --verify-path "$path2"; then
echo "nix-store --verify-path did not detect .links file corruption" >&2 echo "nix-store --verify-path did not detect .links file corruption" >&2
exit 1 exit 1
fi fi
nix-store --repair-path $path2 --substituters "file://$cacheDir" --no-require-sigs --option auto-optimise-store true nix-store --repair-path "$path2" --substituters "file://$cacheDir" --no-require-sigs --option auto-optimise-store true
if [ "$(nix-hash $path2)" != "$hash" -o "BAR" != "$(< $path2/bar)" ]; then # shellcheck disable=SC2166
if [ "$(nix-hash "$path2")" != "$hash" -o "BAR" != "$(< "$path2"/bar)" ]; then
echo "path not repaired properly" >&2 echo "path not repaired properly" >&2
exit 1 exit 1
fi fi