From f57f4c7c24a2016ae64498dd0c22a1193210e540 Mon Sep 17 00:00:00 2001 From: Sergei Zimmerman Date: Fri, 12 Sep 2025 20:43:34 +0300 Subject: [PATCH] Revert "meson: add soversion to libraries (#13960)" This reverts commit bdbc739d6e87f2abf2ded4d38bb0e161f457eb68. Such a change needs more thought put into it. By versioning shared libraries we'd make a false impression that libraries themselves are actually versioned and have some sort of stable ABI, which is not the case. This will be useful when C bindings become stable, but as long as they are experimental it does not make sense to set SONAME. Also this change should not have been backported, since it's severely breaking. (cherry picked from commit 0db2b8c8fe3d944a289a12fee3b3d8ecbeec5240) --- src/libcmd/meson.build | 1 - src/libexpr-c/meson.build | 1 - src/libexpr-test-support/meson.build | 1 - src/libexpr/meson.build | 1 - src/libfetchers-c/meson.build | 1 - src/libfetchers/meson.build | 1 - src/libflake-c/meson.build | 1 - src/libflake/meson.build | 1 - src/libmain-c/meson.build | 1 - src/libmain/meson.build | 1 - src/libstore-c/meson.build | 1 - src/libstore-test-support/meson.build | 1 - src/libstore/meson.build | 1 - src/libutil-c/meson.build | 1 - src/libutil-test-support/meson.build | 1 - src/libutil/meson.build | 1 - 16 files changed, 16 deletions(-) diff --git a/src/libcmd/meson.build b/src/libcmd/meson.build index fbe5e63f6..216d4df9c 100644 --- a/src/libcmd/meson.build +++ b/src/libcmd/meson.build @@ -87,7 +87,6 @@ this_library = library( 'nixcmd', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libexpr-c/meson.build b/src/libexpr-c/meson.build index 83d09ced6..ed4582e40 100644 --- a/src/libexpr-c/meson.build +++ b/src/libexpr-c/meson.build @@ -48,7 +48,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixexprc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libexpr-test-support/meson.build b/src/libexpr-test-support/meson.build index 512330d66..b97f94362 100644 --- a/src/libexpr-test-support/meson.build +++ b/src/libexpr-test-support/meson.build @@ -43,7 +43,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-expr-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libexpr/meson.build b/src/libexpr/meson.build index be837b911..1038d773f 100644 --- a/src/libexpr/meson.build +++ b/src/libexpr/meson.build @@ -179,7 +179,6 @@ this_library = library( parser_tab, lexer_tab, generated_headers, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libfetchers-c/meson.build b/src/libfetchers-c/meson.build index cc4b3990e..e34997f09 100644 --- a/src/libfetchers-c/meson.build +++ b/src/libfetchers-c/meson.build @@ -51,7 +51,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixfetchersc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libfetchers/meson.build b/src/libfetchers/meson.build index c8d049e0f..321146ca4 100644 --- a/src/libfetchers/meson.build +++ b/src/libfetchers/meson.build @@ -60,7 +60,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixfetchers', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libflake-c/meson.build b/src/libflake-c/meson.build index b4f7b2b58..5a81618c8 100644 --- a/src/libflake-c/meson.build +++ b/src/libflake-c/meson.build @@ -51,7 +51,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixflakec', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libflake/meson.build b/src/libflake/meson.build index 0f5b8ee2a..bc8533e15 100644 --- a/src/libflake/meson.build +++ b/src/libflake/meson.build @@ -57,7 +57,6 @@ this_library = library( 'nixflake', sources, generated_headers, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libmain-c/meson.build b/src/libmain-c/meson.build index 42369cfc1..e420520e6 100644 --- a/src/libmain-c/meson.build +++ b/src/libmain-c/meson.build @@ -43,7 +43,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixmainc', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libmain/meson.build b/src/libmain/meson.build index f35fcc709..65fcb6239 100644 --- a/src/libmain/meson.build +++ b/src/libmain/meson.build @@ -76,7 +76,6 @@ this_library = library( 'nixmain', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libstore-c/meson.build b/src/libstore-c/meson.build index bc6c36890..eb5563161 100644 --- a/src/libstore-c/meson.build +++ b/src/libstore-c/meson.build @@ -44,7 +44,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixstorec', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libstore-test-support/meson.build b/src/libstore-test-support/meson.build index 1de6247ab..779b122fa 100644 --- a/src/libstore-test-support/meson.build +++ b/src/libstore-test-support/meson.build @@ -43,7 +43,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-store-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libstore/meson.build b/src/libstore/meson.build index 3ff1e6eb8..3017bac66 100644 --- a/src/libstore/meson.build +++ b/src/libstore/meson.build @@ -344,7 +344,6 @@ this_library = library( generated_headers, sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libutil-c/meson.build b/src/libutil-c/meson.build index 20fcbd5cd..3414a6d31 100644 --- a/src/libutil-c/meson.build +++ b/src/libutil-c/meson.build @@ -52,7 +52,6 @@ this_library = library( 'nixutilc', sources, config_priv_h, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags, diff --git a/src/libutil-test-support/meson.build b/src/libutil-test-support/meson.build index 9e51aed0d..ec6bc15d9 100644 --- a/src/libutil-test-support/meson.build +++ b/src/libutil-test-support/meson.build @@ -40,7 +40,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nix-util-test-support', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, # TODO: Remove `-lrapidcheck` when https://github.com/emil-e/rapidcheck/pull/326 diff --git a/src/libutil/meson.build b/src/libutil/meson.build index 11aa95e62..f5ad2b1f6 100644 --- a/src/libutil/meson.build +++ b/src/libutil/meson.build @@ -185,7 +185,6 @@ subdir('nix-meson-build-support/windows-version') this_library = library( 'nixutil', sources, - soversion : 0, dependencies : deps_public + deps_private + deps_other, include_directories : include_dirs, link_args: linker_export_flags,