nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-12-13 12:31:04 +01:00
Code Activity

* Wrap calls to registerSubstitute() in a single transaction to

Browse source 
improve throughput.
* Don't build the `substitute-rev' table for now, since it caused
  Theta(N^2) time and log file consumption when adding N substitutes.
  Maybe we can do without it.
This commit is contained in:
Eelco Dolstra 2004-06-21 07:38:17 +00:00
parent 15c60ca1b6
commit daf0a923c7
3 changed files with 13 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

12
src/libstore/store.cc
View file

@ -302,19 +302,16 @@ static void writeSubstitutes(const Transaction & txn,
}
void registerSubstitute(const Path & srcPath,
const Substitute & sub)
void registerSubstitute(const Transaction & txn,
const Path & srcPath, const Substitute & sub)
{
assertStorePath(srcPath);
assertStorePath(sub.storeExpr);
Transaction txn(nixDB);
Substitutes subs = readSubstitutes(txn, srcPath);
if (find(subs.begin(), subs.end(), sub) != subs.end()) {
/* Nothing to do if the substitute is already known. */
txn.abort();
return;
}
subs.push_front(sub); /* new substitutes take precedence */
@ -325,10 +322,9 @@ void registerSubstitute(const Path & srcPath,
nixDB.queryStrings(txn, dbSubstitutesRev, sub.storeExpr, revs);
if (find(revs.begin(), revs.end(), srcPath) == revs.end())
revs.push_back(srcPath);
nixDB.setStrings(txn, dbSubstitutesRev, sub.storeExpr, revs);
txn.commit();
// !!! O(n^2) complexity in building this
// nixDB.setStrings(txn, dbSubstitutesRev, sub.storeExpr, revs);
}