nixos/nix
1
1
Fork 0
mirror of https://github.com/NixOS/nix.git synced 2025-11-22 10:19:36 +01:00
Code Activity

libutil: Fix handling of unescaped spaces, quotes and shevrons in queries and fragments

Browse source 
Turns out we didn't have tests for some of the important behavior introduced
for flake reference fragments and url queries [1]. This is rather important
and is relied upon by existing tooling. This fixes up these exact cases before
handing off the URL to the Boost.URL parser.

To the best of my knowledge this implements the same behavior as prior regex-based
parser did [2]:

> fragmentRegex = "(?:" + pcharRegex + "|[/? \"^])*";
> queryRegex = "(?:" + pcharRegex + "|[/? \"])*";

[1]: 9c0a09f09f
[2]: https://github.com/NixOS/nix/blob/2.30.2/src/libutil/include/nix/util/url-parts.hh
This commit is contained in:
Sergei Zimmerman 2025-08-16 23:00:31 +03:00
parent 0fd9ef0cf3
commit dc1b2012af
No known key found for this signature in database
4 changed files with 96 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/libutil/include/nix/util/url.hh
View file

@ -104,8 +104,8 @@ std::string encodeQuery(const StringMap & query);
* Parse a Nix URL into a ParsedURL.
*
* Nix URI is mostly compliant with RFC3986, but with some deviations:
* - Literal spaces are allowed and don't have to be percent encoded.
* This is mostly done for backward compatibility.
* - Fragments can contain unescaped (not URL encoded) '^', '"' or space literals.
* - Queries may contain unescaped '"' or spaces.
*
* @note IPv6 ZoneId literals (RFC4007) are represented in URIs according to RFC6874.
*